<table><tr><td style="">ervin requested changes to this revision.<br />ervin added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27477">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27477#inline-155998">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mouse.cpp:139</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">KTitleBarActionsConfig</span><span style="color: #aa2211">::</span><span class="n">KTitleBarActionsConfig</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">_standAlone</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">KConfig</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">_config</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">QWidget</span> <span style="color: #aa2211">*</span> <span class="n">parent</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa2211">:</span> <span class="n">KCModule</span><span class="p">(</span><span class="n">parent</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">config</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">_config</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n">standAlone</span><span class="p">(</span><span class="n">_standAlone</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">KTitleBarActionsConfig</span><span style="color: #aa2211">::</span><span class="n">KTitleBarActionsConfig</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">_standAlone</span><span class="p">,</span> <span class="n">QWidget</span> <span style="color: #aa2211">*</span> <span class="n">parent</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa2211">:</span> <span class="n">KCModule</span><span class="p">(</span><span class="n">parent</span><span class="p">),</span> <span class="n">standAlone</span><span class="p">(</span><span class="n">_standAlone</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please use the opportunity to remove the space after the *</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27477#inline-155999">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mouse.cpp:159</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">KTitleBarActionsConfig</span><span style="color: #aa2211">::~</span><span class="n">KTitleBarActionsConfig</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">standAlone</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">delete</span> <span class="n">config</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{<span class="bright">}</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I guess it could be completely removed</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27477#inline-156000">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mouse.cpp:207</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">KWindowActionsConfig</span><span style="color: #aa2211">::~</span><span class="n">KWindowActionsConfig</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">standAlone</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">delete</span> <span class="n">config</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">void</span> <span class="n">KWindowActionsConfig</span><span style="color: #aa2211">::</span><span class="n">setComboText</span><span class="p">(</span><span class="n">KComboBox</span><span style="color: #aa2211">*</span> <span class="n">combo</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span><span style="color: #aa2211">*</span><span class="n">txt</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">combo</span> <span style="color: #aa2211">==</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">coWin1</span> <span style="color: #aa2211">||</span> <span class="n">combo</span> <span style="color: #aa2211">==</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">coWin2</span> <span style="color: #aa2211">||</span> <span class="n">combo</span> <span style="color: #aa2211">==</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">coWin3</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">combo</span><span style="color: #aa2211">-></span><span class="n">setCurrentIndex</span><span class="p">(</span><span class="n">tbl_txt_lookup</span><span class="p">(</span><span class="n">tbl_Win</span><span class="p">,</span> <span class="n">txt</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">combo</span> <span style="color: #aa2211">==</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">coWinWheel</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">combo</span><span style="color: #aa2211">-></span><span class="n">setCurrentIndex</span><span class="p">(</span><span class="n">tbl_txt_lookup</span><span class="p">(</span><span class="n">tbl_WinWheel</span><span class="p">,</span> <span class="n">txt</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">combo</span> <span style="color: #aa2211">==</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">coAllKey</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">combo</span><span style="color: #aa2211">-></span><span class="n">setCurrentIndex</span><span class="p">(</span><span class="n">tbl_txt_lookup</span><span class="p">(</span><span class="n">tbl_AllKey</span><span class="p">,</span> <span class="n">txt</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">combo</span> <span style="color: #aa2211">==</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">coAll1</span> <span style="color: #aa2211">||</span> <span class="n">combo</span> <span style="color: #aa2211">==</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">coAll2</span> <span style="color: #aa2211">||</span> <span class="n">combo</span> <span style="color: #aa2211">==</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">coAll3</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">combo</span><span style="color: #aa2211">-></span><span class="n">setCurrentIndex</span><span class="p">(</span><span class="n">tbl_txt_lookup</span><span class="p">(</span><span class="n">tbl_All</span><span class="p">,</span> <span class="n">txt</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">combo</span> <span style="color: #aa2211">==</span> <span class="n">m_ui</span><span style="color: #aa2211">-></span><span class="n">coAllW</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">combo</span><span style="color: #aa2211">-></span><span class="n">setCurrentIndex</span><span class="p">(</span><span class="n">tbl_txt_lookup</span><span class="p">(</span><span class="n">tbl_AllW</span><span class="p">,</span> <span class="n">txt</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #004012">abort</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span><span style="color: #aa2211">*</span> <span class="n">KWindowActionsConfig</span><span style="color: #aa2211">::</span><span class="n">functionWin</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span class="n">tbl_num_lookup</span><span class="p">(</span><span class="n">tbl_Win</span><span class="p">,</span> <span class="n">i</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span><span style="color: #aa2211">*</span> <span class="n">KWindowActionsConfig</span><span style="color: #aa2211">::</span><span class="n">functionWinWheel</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span class="n">tbl_num_lookup</span><span class="p">(</span><span class="n">tbl_WinWheel</span><span class="p">,</span> <span class="n">i</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span><span style="color: #aa2211">*</span> <span class="n">KWindowActionsConfig</span><span style="color: #aa2211">::</span><span class="n">functionAllKey</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span class="n">tbl_num_lookup</span><span class="p">(</span><span class="n">tbl_AllKey</span><span class="p">,</span> <span class="n">i</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span><span style="color: #aa2211">*</span> <span class="n">KWindowActionsConfig</span><span style="color: #aa2211">::</span><span class="n">functionAll</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span class="n">tbl_num_lookup</span><span class="p">(</span><span class="n">tbl_All</span><span class="p">,</span> <span class="n">i</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span><span style="color: #aa2211">*</span> <span class="n">KWindowActionsConfig</span><span style="color: #aa2211">::</span><span class="n">functionAllW</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span class="n">tbl_num_lookup</span><span class="p">(</span><span class="n">tbl_AllW</span><span class="p">,</span> <span class="n">i</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{<span class="bright">}</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27477">https://phabricator.kde.org/D27477</a></div></div><br /><div><strong>To: </strong>meven, crossi, bport, ervin, KWin<br /><strong>Cc: </strong>kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>