<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27060">View Revision</a></tr></table><br /><div><div><p>++</p>
<p>You know my thoughts on per project rules. <br />
But maybe it is different for kwin. Use of setRight() is the easier call than left+width() if you are actually using it for painting and need to think about the 1px the other way round.</p>
<p>But would here work? <a href="https://community.kde.org/Policies/API_to_Avoid#API_that_is_considered_broken" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Policies/API_to_Avoid#API_that_is_considered_broken</a> <br />
if we added a line about "for anything other than painting"</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27060#inline-153211">View Inline</a><span style="color: #4b4d51; font-weight: bold;">coding-conventions.md:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">Exception</span> <span style="color: #601200">1</span><span class="p">:</span> <span class="n">you</span> <span class="n">can</span> <span class="n">use</span> <span class="err">`</span><span class="n">QRect</span><span class="p">::</span><span class="n">moveRight</span><span class="p">()</span><span class="err">`</span> <span class="n">and</span> <span class="err">`</span><span class="n">QRect</span><span class="p">::</span><span class="n">moveBottom</span><span class="p">()</span><span class="err">`</span> <span class="n">to</span> <span class="n">snap</span> <span class="n">a</span> <span class="n">rectangle</span> <span class="n">to</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">another</span> <span class="n">rectangle</span> <span style="color: #aa4000">as</span> <span class="n">long</span> <span style="color: #aa4000">as</span> <span class="n">the</span> <span class="n">corresponding</span> <span class="n">borders</span> <span class="n">match</span><span class="p">,</span> <span style="color: #aa4000">for</span> <span class="n">example</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please say another QRect instead of rectangle.</p>
<p style="padding: 0; margin: 8px;">QRectF source;<br />
QRect target;</p>
<p style="padding: 0; margin: 8px;">target.setRight(source.right());</p>
<p style="padding: 0; margin: 8px;">is problematic</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>coding-conventions</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27060">https://phabricator.kde.org/D27060</a></div></div><br /><div><strong>To: </strong>zzag, KWin, davidedmundson<br /><strong>Cc: </strong>davidedmundson, kwin, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>