<table><tr><td style="">zzag requested changes to this revision.<br />zzag added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26859">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26859#inline-151931">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:1559</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">struct</span> <span class="n">udev_device</span> <span style="color: #aa2211">*</span> <span style="color: #aa4000">const</span> <span class="n">udev_device</span> <span style="color: #aa2211">=</span> <span class="n">libinput_device_get_udev_device</span><span class="p">(</span><span class="n">device</span><span style="color: #aa2211">-></span><span class="n">device</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">devnode</span> <span style="color: #aa2211">=</span> <span class="n">udev_device_get_devnode</span><span class="p">(</span><span class="n">udev_device</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">tabletSeat</span><span style="color: #aa2211">-></span><span class="n">addTablet</span><span class="p">(</span><span class="n">device</span><span style="color: #aa2211">-></span><span class="n">vendor</span><span class="p">(),</span> <span class="n">device</span><span style="color: #aa2211">-></span><span class="n">product</span><span class="p">(),</span> <span class="n">device</span><span style="color: #aa2211">-></span><span class="n">sysName</span><span class="p">(),</span> <span class="n">device</span><span style="color: #aa2211">-></span><span class="n">name</span><span class="p">(),</span> <span class="p">{</span><span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromUtf8</span><span class="p">(</span><span class="n">devnode</span><span class="p">)});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use explicit type</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">char</span> <span style="color: #aa2211">*</span><span class="n">devnode</span> <span style="color: #aa2211">=</span> <span class="n">udev_device_get_devnode</span><span class="p">(</span><span class="n">udev_device</span><span class="p">);</span></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26859#inline-151933">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:1631</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KWayland</span><span style="color: #aa2211">::</span><span class="n">Server</span><span style="color: #aa2211">::</span><span class="n">TabletInterface</span><span style="color: #aa2211">*</span> <span class="n">tablet</span> <span style="color: #aa2211">=</span> <span class="n">tabletSeat</span><span style="color: #aa2211">-></span><span class="n">tabletByName</span><span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">tabletSysName</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Align pointers to right.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26859#inline-151930">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:1633-1636</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Toplevel</span> <span style="color: #aa2211">*</span><span class="n">t</span> <span style="color: #aa2211">=</span> <span class="n">input</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">findToplevel</span><span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">globalPos</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">t</span> <span style="color: #aa2211">||</span> <span style="color: #aa2211">!</span><span class="n">t</span><span style="color: #aa2211">-></span><span class="n">surface</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span style="color: #304a96">false</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No short names.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">Toplevel</span> <span style="color: #aa2211">*</span><span class="n">toplevel</span> <span style="color: #aa2211">=</span> <span class="n">input</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">findToplevel</span><span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">globalPos</span><span class="p">());</span>
<span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">toplevel</span> <span style="color: #aa2211">||</span> <span style="color: #aa2211">!</span><span class="n">toplevel</span><span style="color: #aa2211">-></span><span class="n">surface</span><span class="p">())</span> <span class="p">{</span>
<span style="color: #aa4000">return</span> <span style="color: #304a96">false</span><span class="p">;</span>
<span class="p">}</span></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26859#inline-151929">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:1638</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KWayland</span><span style="color: #aa2211">::</span><span class="n">Server</span><span style="color: #aa2211">::</span><span class="n">SurfaceInterface</span><span style="color: #aa2211">*</span> <span class="n">surface</span> <span style="color: #aa2211">=</span> <span class="n">t</span><span style="color: #aa2211">-></span><span class="n">surface</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">tool</span><span style="color: #aa2211">-></span><span class="n">setCurrentSurface</span><span class="p">(</span><span class="n">surface</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Align pointers to right.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26859#inline-151928">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:1641-1642</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">tool</span><span style="color: #aa2211">-></span><span class="n">isClientSupported</span><span class="p">()</span> <span style="color: #aa2211">||</span> <span style="color: #aa2211">!</span><span class="n">tablet</span><span style="color: #aa2211">-></span><span class="n">resourceForSurface</span><span class="p">(</span><span class="n">surface</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">emulateTabletEvent</span><span class="p">(</span><span class="n">event</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Add missing braces.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26859#inline-151927">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:2064-2065</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_tabletSupport</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">TabletInputFilter</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">auto</span> <span style="color: #a0a000">dev</span> <span class="p">:</span> <span class="n">m_libInput</span><span style="color: #aa2211">-></span><span class="n">devices</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_tabletSupport</span><span style="color: #aa2211">-></span><span class="n">integrateDevice</span><span class="p">(</span><span class="n">dev</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_libInput</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">LibInput</span><span style="color: #aa2211">::</span><span class="n">Connection</span><span style="color: #aa2211">::</span><span class="n">deviceAdded</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please put a single space between <tt style="background: #ebebeb; font-size: 13px;">for</tt> and the opening parenthesis, add missing braces and use explicit type.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26859#inline-151926">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input_event_spy.cpp:124</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">void</span> <span class="n">InputEventSpy</span><span style="color: #aa2211">::</span><span class="n">tabletToolEvent</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">Q</span>TabletEvent<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="n">event</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">InputEventSpy</span><span style="color: #aa2211">::</span><span class="n">tabletToolEvent</span><span class="p">(</span><span class="n">TabletEvent<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n">event</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Align pointers to right.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26859">https://phabricator.kde.org/D26859</a></div></div><br /><div><strong>To: </strong>apol, KWin, Plasma, zzag<br /><strong>Cc: </strong>zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>