<table><tr><td style="">sefaeyeoglu added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18000">View Revision</a></tr></table><br /><div><div><p>I commented on <a href="https://phabricator.kde.org/D25343" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D25343</a> about this. Also note the following inline comment. If we decide on (really) "OutQuad" for slide-in and "InQuad" (or "OutQuad" in code), we just need to adjust L467. Maybe we should also add a comment at L506 that the easing curve will be reversed.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18000#inline-148657">View Inline</a><span style="color: #4b4d51; font-weight: bold;">slidingpopups.cpp:506</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">animation</span><span class="p">.</span><span class="n">timeLine</span><span class="p">.</span><span class="n">setDuration</span><span class="p">((</span><span style="color: #aa2211">*</span><span class="n">dataIt</span><span class="p">).</span><span class="n">slideOutDuration</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">animation</span><span class="p">.</span><span class="n">timeLine</span><span class="p">.</span><span class="n">setEasingCurve</span><span class="p">(</span><span class="n">QEasingCurve</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">InOutSine</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">animation</span><span class="p">.</span><span class="n">timeLine</span><span class="p">.</span><span class="n">setEasingCurve</span><span class="p">(</span><span class="n">QEasingCurve</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">OutQuad</span></span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Technically the "OutQuad" here turns into "InQuad". In L504 the animation is reversed, which also reverses the easing curve.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18000">https://phabricator.kde.org/D18000</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, zzag, KWin, sefaeyeoglu, ndavis<br /><strong>Cc: </strong>niccolove, ngraham, abetts, davidedmundson, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, sebas, apol, ahiemstra, mart<br /></div>