<table><tr><td style="">romangg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25299">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25299#576016" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D25299#576016</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Urgh, no.</p>
<p>I had an unsubmitteed comment for moving forwards.</p>
<p>This patch takes 1 step backwards in order to eventually go 2 steps forward.</p></div>
</blockquote>
<p>With this patch we don't go backwards. This was maybe true for the earlier series at <a href="https://phabricator.kde.org/R108:8d137290317a25aeff9b2abcc0914395e1903aa5" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">8d13729031</a> which got rid of all the super old dysfunctional code and after which frames were pushed without alignment on X11 and always with a full frame timer delay even with swap events. But this was merged also a month ago to master and nobody died. The patch series here does fix these issues.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>A perfectly sensible strategy, but I don't like having master that goes backwards without a completely solid plan to go forward.<br />
The risk of things not getting completed and us releasing something that makes things worse are too high.</p></blockquote>
<p>"Perfect" and "completely solid" are unachievable and converging against it has diminishing return. So we need to find a balance between changes going in without any plan and safeguarding things to the point where everything is cemented in and does not move anymore. I am sure we would be at the same point of incomprehensible and faulty compositing as until only few months ago wouldn't I have been willing to take the risk not having implemented everything perfectly from the start.</p>
<p>I had a plan and this one I outlined publicly in task <a href="https://phabricator.kde.org/T11071" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T11071</a> and the testing ground <a href="https://phabricator.kde.org/D23105" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23105</a>. I got some feedback and adapted my plan on what I learned. Then I moved forward without further delays.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>But I don't want to hold this up, so in order to resolve this in a way where we can all keep moving forward, I have a proposal:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">I'll approve it, but we merge this commit as-is into a feature branch, rather than master</li>
<li class="remarkup-list-item">We can then then do the next review based on that branch</li>
<li class="remarkup-list-item">We can work, hack, rebase and submit reviews on that branch (and vlad and I can help run and rebase it and whatever)</li>
<li class="remarkup-list-item">Master stays "sunny"
<br /><br />
Then when we have the vsync timer we can merge this all into master. Everyone wins.</li>
</ul></blockquote>
<p>Oh, I definitely would have wanted this in master anyways because then Fredrik can base his Nvidia work on it. Since I don't have such direct communication channels to him as to you and Vlad my assumption is that this would lead to unreasonable delay and/or frustration on his side.</p>
<p>If we want to facilitate coordinated feature branch development aside from master we can talk about it, but currently no such facilities besides I guess some company-internal ones at Blue Systems are in place for such.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25299">https://phabricator.kde.org/D25299</a></div></div><br /><div><strong>To: </strong>romangg, KWin<br /><strong>Cc: </strong>kwin, davidedmundson, zzag, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>