<table><tr><td style="">romangg requested changes to this revision.<br />romangg added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25663">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">I suppose this is related to <a href="https://phabricator.kde.org/T11660" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T11660</a>? If so relate the diff and the object.</li>
<li class="remarkup-list-item">Improve commit message, explain your future steps.</li>
<li class="remarkup-list-item">For touch events we already have a fallback to pointer events in KWayland in case the client does not support touch events. I would prefer that we follow the same pattern with tablet events. Otherwise argue why a input event filter is better suited in this case.</li>
<li class="remarkup-list-item">Adhere to styling rules. From what I have seen:<ul class="remarkup-list">
<li class="remarkup-list-item">Line length</li>
<li class="remarkup-list-item">Brackets</li>
<li class="remarkup-list-item">Enum definition</li>
</ul></li>
<li class="remarkup-list-item">libinput interfacing code looks good</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-144715">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:1540</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">id</span> <span style="color: #aa2211">=</span> <span class="n">event</span><span style="color: #aa2211">-></span><span class="n">uniqueId</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">switch</span> <span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">type</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unused</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-144714">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:1563</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">private</span><span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">PointerInputRedirection</span> <span style="color: #aa2211">*</span><span class="n">m_pointer</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There is a <tt style="background: #ebebeb; font-size: 13px;">input()->pointer()</tt> getter. Remove member variable.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-144711">View Inline</a><span style="color: #4b4d51; font-weight: bold;">connection.cpp:471</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KWin</span><span style="color: #aa2211">::</span><span class="n">InputRedirection</span><span style="color: #aa2211">::</span><span class="n">TabletEventType</span> <span class="n">t</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">switch</span> <span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">type</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do not use single letter variable names. Minimum two letters. Same below with <tt style="background: #ebebeb; font-size: 13px;">e</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-144710">View Inline</a><span style="color: #4b4d51; font-weight: bold;">events.h:220</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">// qreal sizeMajor() const { return libinput_event_tablet_tool_get_size_major(m_tabletToolEvent); }</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">// qreal sizeMinor() const { return libinput_event_tablet_tool_get_size_minor(m_tabletToolEvent); }</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qreal</span> <span style="color: #004012">wheelDelta</span><span class="p">()</span> <span style="color: #aa4000">const</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">libinput_event_tablet_tool_get_wheel_delta</span><span class="p">(</span><span class="n">m_tabletToolEvent</span><span class="p">);</span> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Implement or add a notice why these are commented out / a TODO.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-144704">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pointer_input.h:60</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">uint32_t</span> <span class="n">qtMouseButtonToButton</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">MouseButton</span> <span class="n">button</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Change to hash and getter in separate patch. Under the assumption we keep the new input event filter this needs to go into input.h/input.cpp or some other device-independent file and not anymore in pointer_input.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25663">https://phabricator.kde.org/D25663</a></div></div><br /><div><strong>To: </strong>apol, Plasma, KWin, romangg<br /><strong>Cc: </strong>romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>