<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24455">View Revision</a></tr></table><br /><div><div><p>Technically there's one potentially interesting behavioural change. <br />
If a client is server side decorated and then draws a subsurface outside the main surface, previously I believe we would have drawn our frame over the main surface, whereas now I think we'll draw our frame over the union. Probably not a real world issue though.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24455#inline-142695">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xdgshellclient_test.cpp:1311</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">client</span><span style="color: #aa2211">-></span><span class="n">frameGeometry</span><span class="p">().</span><span class="n">topLeft</span><span class="p">(),</span> <span class="n">oldPosition</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">client</span><span style="color: #aa2211">-></span><span class="n">frameGeometry</span><span class="p">().</span><span class="n">size</span><span class="p">(),</span> <span class="n">QSize</span><span class="p">(</span><span style="color: #601200">120</span><span class="p">,</span> <span style="color: #601200">60</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">client</span><span style="color: #aa2211">-></span><span class="n">bufferGeometry</span><span class="p">().</span><span class="n">topLeft</span><span class="p">(),</span> <span class="n">oldPosition</span> <span style="color: #aa2211">+</span> <span class="n">QPoint</span><span class="p">(</span><span style="color: #601200">20</span><span class="p">,</span> <span style="color: #601200">10</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Generally it's a lot easier to read something like</p>
<p style="padding: 0; margin: 8px;">QCOMPARE(..., QSize(100 + 20, 50 + 10));</p>
<p style="padding: 0; margin: 8px;">and then it's apparent where the new numbers come from</p>
<p style="padding: 0; margin: 8px;">(don't bother changing it though)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24455#inline-142701">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xdgshellclient.cpp:549</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">old</span> <span style="color: #aa2211">=</span> <span class="n">geometryBeforeUpdateBlocking</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">addRepaintDuringGeometryUpdates</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">updateGeometryBeforeUpdateBlocking</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the</p>
<p style="padding: 0; margin: 8px;">if (!m_unampped) has gone</p>
<p style="padding: 0; margin: 8px;">Arguably it's a non issue as we'll just trigger a repaint that will in turn not do anything, but I'm wondering if it was there deliberately.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24455#inline-141309">View Inline</a><span style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: #4b4d51; font-weight: bold;">xdgshellclient.h:197</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Will change. I added this bool to avoid a few unnecessary comparisons in QRect::isValid. However, I guess it's a premature optimization.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It makes sense to keep a boolean to see if it's externally set or implicitly set. I think with a rename to<br />
m_windowGeometryExplicitlySet or something it's fine.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24455">https://phabricator.kde.org/D24455</a></div></div><br /><div><strong>To: </strong>zzag, KWin, davidedmundson<br /><strong>Cc: </strong>davidedmundson, romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>