<table><tr><td style="">fvogt added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22571">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22571#inline-129034">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fvogt</span> wrote in <span style="color: #4b4d51; font-weight: bold;">wayland_server.cpp:223</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">AFAICT, "We're comparing a process with itself." is still the case.</p>
<p style="padding: 0; margin: 8px;">It would need to compare the content of <tt style="background: #ebebeb; font-size: 13px;">client->executablePath()</tt> with <tt style="background: #ebebeb; font-size: 13px;">/proc/pid/exe</tt>, but even that can be faked easily.</p>
<p style="padding: 0; margin: 8px;">Note that procfs is unusual - sha256("/proc/pid/exe") != sha256(readlink("/proc/pid/exe"))</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Any news on this?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22571">https://phabricator.kde.org/D22571</a></div></div><br /><div><strong>To: </strong>apol, Plasma, KWin, davidedmundson<br /><strong>Cc: </strong>fvogt, zzag, broulik, graesslin, davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart<br /></div>