<table><tr><td style="">zzag created this revision.<br />zzag added a reviewer: KWin.<br />Herald added a project: KWin.<br />Herald added a subscriber: kwin.<br />zzag requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23618">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Because KWin is a very old project, we use three kinds of null literals:<br />
0, NULL, and nullptr. Since C++11, it's recommended to use nullptr keyword.</p>
<p>This change converts all usages of 0 and NULL literal to nullptr. Even<br />
though it breaks git history, we need to do it in order to have consistent<br />
code as well to ease code reviews (it's very tempting for some people to<br />
add unrelated changes to their patches, e.g. converting NULL to nullptr).</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Compiles.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>use-nullptr-everywhere</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23618">https://phabricator.kde.org/D23618</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>abstract_client.cpp<br />
activation.cpp<br />
activities.cpp<br />
client.cpp<br />
client.h<br />
client_machine.cpp<br />
client_machine.h<br />
colorcorrection/manager.cpp<br />
composite.cpp<br />
composite.h<br />
cursor.cpp<br />
deleted.cpp<br />
effects.cpp<br />
effects/backgroundcontrast/contrastshader.cpp<br />
effects/blur/blur_config.h<br />
effects/coverswitch/coverswitch.cpp<br />
effects/coverswitch/coverswitch.h<br />
effects/coverswitch/coverswitch_config.h<br />
effects/cube/cube.cpp<br />
effects/cube/cube_config.h<br />
effects/cubeslide/cubeslide.cpp<br />
effects/cubeslide/cubeslide_config.h<br />
effects/desktopgrid/desktopgrid.cpp<br />
effects/desktopgrid/desktopgrid.h<br />
effects/desktopgrid/desktopgrid_config.h<br />
effects/flipswitch/flipswitch.cpp<br />
effects/flipswitch/flipswitch_config.h<br />
effects/highlightwindow/highlightwindow.cpp<br />
effects/highlightwindow/highlightwindow.h<br />
effects/invert/invert.cpp<br />
effects/invert/invert_config.h<br />
effects/lookingglass/lookingglass.cpp<br />
effects/lookingglass/lookingglass_config.h<br />
effects/magiclamp/magiclamp.cpp<br />
effects/magiclamp/magiclamp_config.h<br />
effects/magnifier/magnifier.cpp<br />
effects/magnifier/magnifier_config.h<br />
effects/mouseclick/mouseclick.cpp<br />
effects/mouseclick/mouseclick_config.h<br />
effects/mousemark/mousemark.cpp<br />
effects/mousemark/mousemark_config.h<br />
effects/presentwindows/presentwindows.cpp<br />
effects/presentwindows/presentwindows.h<br />
effects/presentwindows/presentwindows_config.h<br />
effects/resize/resize.cpp<br />
effects/resize/resize_config.h<br />
effects/screenedge/screenedgeeffect.cpp<br />
effects/screenshot/screenshot.cpp<br />
effects/showfps/showfps.cpp<br />
effects/showfps/showfps_config.h<br />
effects/slideback/slideback.cpp<br />
effects/startupfeedback/startupfeedback.cpp<br />
effects/thumbnailaside/thumbnailaside.cpp<br />
effects/thumbnailaside/thumbnailaside_config.h<br />
effects/touchpoints/touchpoints.cpp<br />
effects/trackmouse/trackmouse.cpp<br />
effects/trackmouse/trackmouse_config.h<br />
effects/windowgeometry/windowgeometry.cpp<br />
effects/windowgeometry/windowgeometry_config.h<br />
effects/wobblywindows/wobblywindows_config.h<br />
effects/zoom/zoom.cpp<br />
effects/zoom/zoom_config.h<br />
events.cpp<br />
focuschain.cpp<br />
geometry.cpp<br />
geometrytip.cpp<br />
group.cpp<br />
input.cpp<br />
kcmkwin/kwincompositing/compositing.h<br />
kcmkwin/kwincompositing/main.cpp<br />
kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.h<br />
kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp<br />
kcmkwin/kwindecoration/declarative-plugin/previewsettings.h<br />
kcmkwin/kwinoptions/mouse.cpp<br />
kcmkwin/kwinscreenedges/monitor.h<br />
kcmkwin/kwintabbox/thumbnailitem.cpp<br />
layers.cpp<br />
libkwineffects/kwinglplatform.cpp<br />
libkwineffects/kwinglutils.cpp<br />
manage.cpp<br />
netinfo.cpp<br />
options.h<br />
placement.cpp<br />
platformsupport/scenes/opengl/backend.cpp<br />
platformsupport/scenes/opengl/linux_dmabuf.cpp<br />
plugins/idletime/poller.h<br />
plugins/kglobalaccel/kglobalaccel_plugin.h<br />
plugins/platforms/wayland/wayland_backend.cpp<br />
plugins/platforms/x11/standalone/glxbackend.cpp<br />
plugins/platforms/x11/standalone/overlaywindow_x11.cpp<br />
plugins/platforms/x11/standalone/windowselector.cpp<br />
plugins/qpa/sharingplatformcontext.cpp<br />
plugins/scenes/opengl/lanczosfilter.cpp<br />
plugins/scenes/opengl/lanczosfilter.h<br />
plugins/scenes/opengl/scene_opengl.cpp<br />
plugins/scenes/opengl/scene_opengl.h<br />
plugins/scenes/qpainter/scene_qpainter.cpp<br />
plugins/scenes/xrender/scene_xrender.cpp<br />
scene.cpp<br />
screenedge.cpp<br />
screens.cpp<br />
scripting/dbuscall.h<br />
scripting/screenedgeitem.h<br />
scripting/workspace_wrapper.cpp<br />
shadow.cpp<br />
sm.cpp<br />
tabbox/tabbox.cpp<br />
tabgroup.cpp<br />
tabgroup.h<br />
tests/pointerconstraintstest.cpp<br />
thumbnailitem.cpp<br />
thumbnailitem.h<br />
toplevel.cpp<br />
unmanaged.cpp<br />
useractions.cpp<br />
useractions.h<br />
utils.cpp<br />
virtualdesktops.cpp<br />
workspace.cpp<br />
workspace.h<br />
xcbutils.cpp<br />
xcbutils.h<br />
xkb.cpp<br />
xwl/drag_x.cpp<br />
xwl/transfer.cpp</div></div></div><br /><div><strong>To: </strong>zzag, KWin<br /><strong>Cc: </strong>kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart<br /></div>