<table><tr><td style="">zzag requested changes to this revision.<br />zzag added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23415">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D23415#519223" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23415#519223</a>, <a href="https://phabricator.kde.org/p/cfeck/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cfeck</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Is zero corner top-right on RTL systems?</p></div>
</blockquote>
<p>No, this placement policy doesn't take into account writing system.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D23415#519103" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23415#519103</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I've standardized on the descriptive mood now. But I have not reverted back to "Smart" because it's simply a bad name, and it doesn't make sense to keep it. It doesn't matter what the feature is called internally, and how long it's had that name is irrelevant if it's a bad name. And "Smart" is a bad name because unlike all the other window placement modes, it is a generic meaningless term whose name does not explain or hint at what it will do. User-visible strings are crafted for the benefit of the user, not the developer.</p>
<p>Also I don't think renaming the enums is a good idea:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">If the point is to retain naming consistency throughout the codebase, then we'd need to update the strings written to and read from the config files as well, which would necessitate a kconf update script, which seems like total overkill; no other KDE project imposes such a high bar for simple string changes</li>
<li class="remarkup-list-item">If, to avoid the above, we just rename the enums but not all occurrences in the codebase, then we haven't actually maintained consistency, and there's no point in doing any code renaming at all</li>
</ul></div>
</blockquote>
<p>I didn't say to touch serialized config values. I said only to adjust enum names. that's it.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D23415#519226" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23415#519226</a>, <a href="https://phabricator.kde.org/p/ndavis/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ndavis</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Catchiness is important if you're going to use it for marketing, but you never see KDE promoting the smart placement feature and people on forums rarely talk about it. Just because it has had a bad name since 1999, doesn't mean it should continue to be bad for another 20 years.</p></div>
</blockquote>
<p>This placement policy has been called "smart" for two decades. Many people are used to this name and I don't want to change things for old-school or current users.</p>
<p>I get your point about the name not being very descriptive but if you really want to make these names intuitive, then there should be some demo along the placement policy combobox in the kcm.</p>
<p>I don't want to discuss this topic anymore because we won't find common ground. Don't rename smart placement policy!</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23415">https://phabricator.kde.org/D23415</a></div></div><br /><div><strong>To: </strong>ngraham, KWin, VDG, ndavis, filipf, zzag<br /><strong>Cc: </strong>romangg, cfeck, filipf, zzag, ndavis, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>