<table><tr><td style="">gladhorn updated this revision to Diff 63498.<br />gladhorn retitled this revision from "Remove dead code" to "Remove disabled TabGroup feature".<br />gladhorn edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-3b37vr7tcal2zf5/">(Show Details)</a><br />gladhorn added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23069">View Revision</a></tr></table><br /><div><div><p>Attempt to remove entire tabgroup feature.</p>
<p>If this is not wanted, then I won't spend more time on it, but it was<br />
interesting to see how much code this really is.<br />
If this is something that you think should land, then there are one or two<br />
fixmes that need to be addressed.</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;">This has been commented out since 2014, I doubt it will come back.<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
This is a big amount of code, maintenance will be easier without it.</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D23069?vs=63468&id=63498">https://phabricator.kde.org/D23069?vs=63468&id=63498</a></div></div><br /><div><strong>BRANCH</strong><div><div>tabgroup</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23069">https://phabricator.kde.org/D23069</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
abstract_client.cpp<br />
abstract_client.h<br />
activation.cpp<br />
client.cpp<br />
client.h<br />
deleted.cpp<br />
deleted.h<br />
effects.cpp<br />
geometry.cpp<br />
input.cpp<br />
kwinbindings.cpp<br />
layers.cpp<br />
libkwineffects/kwineffects.h<br />
manage.cpp<br />
options.h<br />
placement.cpp<br />
scene.cpp<br />
scripting/scripting_model.cpp<br />
shell_client.cpp<br />
sm.cpp<br />
sm.h<br />
tabgroup.cpp<br />
tabgroup.h<br />
toplevel.cpp<br />
useractions.cpp<br />
useractions.h<br />
workspace.cpp<br />
workspace.h</div></div></div><br /><div><strong>To: </strong>gladhorn, KWin<br /><strong>Cc: </strong>romangg, graesslin, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>