<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23011">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23011#inline-129818">View Inline</a><span style="color: #4b4d51; font-weight: bold;">composite.cpp:272-273</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">platform</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setSelectedCompositor</span><span class="p">(</span><span class="n">m_scene</span><span style="color: #aa2211">-></span><span class="n">compositingType</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span class="n">OpenGLCompositing</span> <span style="color: #aa2211">?<span class="bright"></span></span><span class="bright"> </span><span style="color: #a0a000"><span class="bright">OpenGLCompositing</span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span><span class="bright"> </span><span class="n"><span class="bright">m_scene</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">compositingType</span></span><span class="bright"></span><span class="p"><span class="bright">());</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">platform</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setSelectedCompositor</span><span class="p">(</span><span class="n">m_scene</span><span style="color: #aa2211">-></span><span class="n">compositingType</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span class="n">OpenGLCompositing</span> <span style="color: #aa2211">?</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #a0a000">OpenGLCompositing</span> <span class="p">:</span> <span class="n">m_scene</span><span style="color: #aa2211">-></span><span class="n">compositingType</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Personal opinion: I don't like that the ternary operator is minding its own business somewhere far right.</p>
<p style="padding: 0; margin: 8px;">A better approach imho</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">CompositingType</span> <span class="n">compositingType</span> <span style="color: #aa2211">=</span> <span class="n">m_scene</span><span style="color: #aa2211">-></span><span class="n">compositingType</span><span class="p">();</span>
<span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">compositingType</span> <span style="color: #aa2211">&</span> <span class="n">OpenGLCompositing</span><span class="p">)</span> <span class="p">{</span>
<span class="n">compositingType</span> <span style="color: #aa2211">=</span> <span class="n">OpenGLCompositing</span><span class="p">;</span>
<span class="p">}</span>
<span style="color: #74777d">// ... one day</span>
<span style="color: #74777d">// if (compositingType & VulkanCompositing) {</span>
<span style="color: #74777d">// compositingType = VulkanCompositing;</span>
<span style="color: #74777d">// }</span>
<span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">platform</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setSelectedCompositor</span><span class="p">(</span><span class="n">compositingType</span><span class="p">);</span></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23011#inline-129811">View Inline</a><span style="color: #4b4d51; font-weight: bold;">composite.cpp:309</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">auto</span> <span class="bright"></span><span class="n"><span class="bright">c</span></span> <span style="color: #aa2211">=</span> <span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">x11Connection</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">c</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">con</span></span> <span style="color: #aa2211">=</span> <span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">x11Connection</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">c<span class="bright">on</span></span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No short names.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23011#inline-129813">View Inline</a><span style="color: #4b4d51; font-weight: bold;">composite.cpp:334</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n"><span class="bright">w</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">waylandServer</span></span><span class="bright"></span><span class="p"><span class="bright">())</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000">auto</span> <span class="bright"></span><span class="n"><span class="bright">clients</span></span> <span style="color: #aa2211">=</span> <span class="n">w<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">clients</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">for</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span style="color: #aa4000">auto</span> <span style="color: #a0a000">c<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span><span class="bright"> </span><span class="n">clients<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span style="color: #aa4000">auto</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">server</span></span> <span style="color: #aa2211">=</span> <span class="n">w<span class="bright">aylandServer</span></span><span class="bright"></span><span class="p"><span class="bright">())</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">c<span class="bright">lients</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">server</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="n">clients<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">ShellClient</span> <span style="color: #aa2211">*</span><span style="color: #a0a000">c</span> <span class="p">:</span> <span class="n">clients</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why did you remove auto?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23011#inline-129819">View Inline</a><span style="color: #4b4d51; font-weight: bold;">composite.cpp:350</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span class="n"><span class="bright">foreach</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">Client</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">c</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">Workspace</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">self</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">clientList</span></span><span class="bright"></span><span class="p"><span class="bright">())</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">Client</span> <span style="color: #aa2211">*</span><span style="color: #a0a000">c</span> <span class="p">:</span> <span class="n">Workspace</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">clientList</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">c</span><span style="color: #aa2211">-></span><span class="n">setupCompositing</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If you want to follow the frameworks coding style 100%, then it should be ShellClient *client.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23011#inline-129814">View Inline</a><span style="color: #4b4d51; font-weight: bold;">composite.cpp:698-699</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_framesToTestForSafety</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span class="n">m_scene</span><span style="color: #aa2211">-></span><span class="n">compositingType</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span class="n">OpenGLCompositing</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">platform</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">createOpenGLSafePoint</span><span class="p">(</span><span class="n">Platform</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">OpenGLSafePoint</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">PostLastGuardedFrame</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">platform</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">createOpenGLSafePoint</span><span class="p">(</span><span class="n">Platform</span><span style="color: #aa2211">::</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">OpenGLSafePoint</span><span style="color: #aa2211">::</span><span class="n">PostLastGuardedFrame</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That's unusual line breaking.</p>
<p style="padding: 0; margin: 8px;">A bit better imho</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">kwinApp</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">platform</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">createOpenGLSafePoint</span><span class="p">(</span>
<span class="n">Platform</span><span style="color: #aa2211">::</span><span class="n">OpenGLSafePoint</span><span style="color: #aa2211">::</span><span class="n">PostLastGuardedFrame</span><span class="p">);</span></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23011#inline-129816">View Inline</a><span style="color: #4b4d51; font-weight: bold;">composite.cpp:948</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">shortcuts</span> <span style="color: #aa2211">=</span> <span class="n">KGlobalAccel</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">shortcut</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">workspace</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">findChild</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">QAction</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Suspend Compositing"</span></span><span class="bright"></span><span class="p"><span class="bright">)));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">shortcuts</span> <span style="color: #aa2211">=</span> <span class="n">KGlobalAccel</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">shortcut</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">workspace</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">findChild</span><span style="color: #aa2211"><</span><span class="n">QAction</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Suspend Compositing"</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">shortcuts</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Indent only with 4 spaces.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23011">https://phabricator.kde.org/D23011</a></div></div><br /><div><strong>To: </strong>romangg, KWin<br /><strong>Cc: </strong>zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart<br /></div>