<table><tr><td style="">filipf accepted this revision.<br />filipf added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22830">View Revision</a></tr></table><br /><div><div><p>Nice work.</p>

<p>There's a binding loop that doesn't look trivial to solve, but doesn't seem to affect anything.</p>

<p><tt style="background: #ebebeb; font-size: 13px;">file:///usr/share/kpackage/kcms/kcm_kwin_effects/contents/ui/main.qml:96:19: QML SwipeListItem: Binding loop detected for property "implicitHeight"</tt></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D22830</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22830">https://phabricator.kde.org/D22830</a></div></div><br /><div><strong>To: </strong>davidre, KWin, VDG, filipf, GB_2<br /><strong>Cc: </strong>ngraham, GB_2, filipf, kwin, LeGast00n, fmonteiro, sbergeron, jraleigh, fbampaloukas, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart<br /></div>