<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22295">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22295#inline-126788">View Inline</a><span style="color: #4b4d51; font-weight: bold;">composite.cpp:795</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_state</span> <span style="color: #aa2211">!=</span> <span class="n">State</span><span style="color: #aa2211">::</span><span class="n">On</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_state</span> <span style="color: #aa2211">!=</span> <span class="n">State</span><span style="color: #aa2211">::</span><span class="n">On<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">compositeTimer</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">isActive</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It's a matter of personal taste, but maybe if statements should check only related stuff(i.e. don't inflate conditionals). Whether compositing is active and whether the composite timer is active seem to be unrelated.</p>

<p style="padding: 0; margin: 8px;">Also, this will be a great idea to document when the composite timer condition can be fulfilled.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_state</span> <span style="color: #aa2211">!=</span> <span class="n">State</span><span style="color: #aa2211">::</span><span class="n">On</span><span class="p">)</span> <span class="p">{</span>
    <span style="color: #aa4000">return</span><span class="p">;</span>
<span class="p">}</span>

<span style="color: #74777d">// This if statements checks something completely different, thus it's not</span>
<span style="color: #74777d">// merged with the previous if statement.</span>
<span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">compositeTimer</span><span class="p">.</span><span class="n">isActive</span><span class="p">())</span> <span class="p">{</span>
    <span style="color: #aa4000">return</span><span class="p">;</span>
<span class="p">}</span></pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22295">https://phabricator.kde.org/D22295</a></div></div><br /><div><strong>To: </strong>romangg, KWin<br /><strong>Cc: </strong>zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>