<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21746">View Revision</a></tr></table><br /><div><div><p>DontCrashGlxgearsTest fails on my machine</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">[vlad@lithium kwin]$ rm -rf ~/.qttest/
[vlad@lithium kwin]$ dbus-run-session bin/testDontCrashGlxgears
QFile::remove: Empty or null file name
********* Start testing of KWin::DontCrashGlxgearsTest *********
Config: Using QtTest library 5.13.0, Qt 5.13.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 8.3.0)
_XSERVTransSocketUNIXCreateListener: ...SocketCreateListener() failed
_XSERVTransMakeAllCOTSServerListeners: server already running
glamor: No eglstream capable devices found
glamor: 'wl_drm' not supported
Missing Wayland requirements for glamor GBM backend
Missing Wayland requirements for glamor EGLStream backend
Failed to initialize glamor, falling back to sw
The XKEYBOARD keymap compiler (xkbcomp) reports:
> Warning: Unsupported high keycode 372 for name <I372> ignored
> X11 cannot support keycodes above 255.
> This warning only shows for the first high keycode.
> Internal error: Could not resolve keysym XF86MonBrightnessCycle
> Internal error: Could not resolve keysym XF86RotationLockToggle
Errors from xkbcomp are not fatal to the X server
X-Server started on display :1
PASS : KWin::DontCrashGlxgearsTest::initTestCase()
The XKEYBOARD keymap compiler (xkbcomp) reports:
> Warning: Unsupported maximum keycode 569, clipping.
> X11 cannot support keycodes above 255.
> Warning: Unsupported high keycode 372 for name <I372> ignored
> X11 cannot support keycodes above 255.
> This warning only shows for the first high keycode.
> Internal error: Could not resolve keysym XF86MonBrightnessCycle
> Internal error: Could not resolve keysym XF86RotationLockToggle
Errors from xkbcomp are not fatal to the X server
QWARN : KWin::DontCrashGlxgearsTest::testGlxgears() Module 'org.kde.kwin.decoration' does not contain a module identifier directive - it cannot be protected from external registrations.
QWARN : KWin::DontCrashGlxgearsTest::testGlxgears() QQmlComponent: Component is not ready
QWARN : KWin::DontCrashGlxgearsTest::testGlxgears() org.kde.kwindowsystem.keyserver.x11: X11 implementation of KKeyServer accessed from non-X11 platform! This is an application bug.
FAIL! : KWin::DontCrashGlxgearsTest::testGlxgears() 'mousePressevent.isAccepted()' returned FALSE. ()
Loc: [/home/vlad/Workspace/KDE/src/kde/workspace/kwin/autotests/integration/dont_crash_glxgears.cpp(86)]
QWARN : KWin::DontCrashGlxgearsTest::testGlxgears() QProcess: Destroyed while process ("glxgears") is still running.
PASS : KWin::DontCrashGlxgearsTest::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 364ms
********* Finished testing of KWin::DontCrashGlxgearsTest *********
QSocketNotifier: Invalid socket 19 with type Read, disabling...</pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21746#inline-124575">View Inline</a><span style="color: #4b4d51; font-weight: bold;">maximize_test.cpp:145</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span class="n"><span class="bright">QCOMPARE</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">geometryShapeChangedSpy</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">count</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// If no borders, there is only the initial geometry shape cahnge, but none through border resizing.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">geometryShapeChangedSpy</span><span class="p">.</span><span class="n">count</span><span class="p">(),</span> <span class="n">hasBorders</span> <span style="color: #aa2211">?</span> <span style="color: #601200">2</span> <span style="color: #aa2211">:</span> <span style="color: #601200">1</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There is a typo in the word "change."</p>
<p style="padding: 0; margin: 8px;">I wonder why the linter is silent.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21746">https://phabricator.kde.org/D21746</a></div></div><br /><div><strong>To: </strong>romangg, KWin<br /><strong>Cc: </strong>zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>