<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21916">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21916#inline-123423">View Inline</a><span style="color: #4b4d51; font-weight: bold;">eglonxbackend.cpp:281-285</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">surface</span> <span style="color: #aa2211">=</span> <span class="n">eglCreatePlatformWindowSurfaceEXT</span><span class="p">(</span><span class="n">eglDisplay</span><span class="p">(),</span> <span class="n">config</span><span class="p">(),</span> <span class="p">(</span><span style="color: #aa4000">void</span> <span style="color: #aa2211">*</span><span class="p">)</span> <span style="color: #aa2211">&</span><span class="n">window</span><span class="p">,<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">surface</span> <span style="color: #aa2211">=</span> <span class="n">eglCreatePlatformWindowSurfaceEXT</span><span class="p">(</span><span class="n">eglDisplay</span><span class="p">(),</span> <span class="n">config</span><span class="p">(),</span> <span class="p">(</span><span style="color: #aa4000">void</span> <span style="color: #aa2211">*</span><span class="p">)</span> <span style="color: #aa2211">&</span><span class="n">window</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                    <span style="color: #aa2211">!</span><span class="n">isOpenGLES</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">hasEglColorspace</span> <span style="color: #aa2211">?</span> <span style="color: #a0a000">attr</span> <span class="p">:</span> <span style="color: #aa4000">nullptr</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">surface</span> <span style="color: #aa2211">=</span> <span class="n">eglCreateWindowSurface</span><span class="p">(</span><span class="n">eglDisplay</span><span class="p">(),</span> <span class="n">config</span><span class="p">(),</span> <span class="n">window</span><span class="p">,<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">surface</span> <span style="color: #aa2211">=</span> <span class="n">eglCreateWindowSurface</span><span class="p">(</span><span class="n">eglDisplay</span><span class="p">(),</span> <span class="n">config</span><span class="p">(),</span> <span class="n">window</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                         <span style="color: #aa2211">!</span><span class="n">isOpenGLES</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">hasEglColorspace</span> <span style="color: #aa2211">?</span> <span style="color: #a0a000">attr</span> <span class="p">:</span> <span style="color: #aa4000">nullptr</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There's another way to implement this, e.g.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">int</span> <span class="n">nattrs</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span style="color: #74777d">// or int cursor = 0;</span>
<span style="color: #aa4000">int</span> <span class="n">attrs</span><span class="p">[]</span> <span style="color: #aa2211">=</span> <span class="p">{</span>
    <span class="n">EGL_NONE</span><span class="p">,</span> <span class="n">EGL_NONE</span><span class="p">,</span>
    <span class="n">EGL_NONE</span>
<span class="p">};</span>

<span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">isOpenGLES</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">hasEglColorspace</span><span class="p">)</span> <span class="p">{</span>
    <span class="n">attrs</span><span class="p">[</span><span class="n">nattrs</span><span style="color: #aa2211">++</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">EGL_GL_COLORSPACE</span><span class="p">;</span>
    <span class="n">attrs</span><span class="p">[</span><span class="n">nattrs</span><span style="color: #aa2211">++</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">EGL_GL_COLORSPACE_SRGB</span><span class="p">;</span>
<span class="p">}</span>

<span style="color: #74777d">// ...</span></pre></div>

<p style="padding: 0; margin: 8px;">perhaps that's a matter of personal taste. :-)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21916">https://phabricator.kde.org/D21916</a></div></div><br /><div><strong>To: </strong>fredrik, KWin<br /><strong>Cc: </strong>zzag, sbergeron, kwin, LeGast00n, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>