<html><head><style id="outgoing-font-settings">#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;}</style></head><body style="background-color: rgb(255, 255, 255); background-image: initial; line-height: initial;"><div id="response_container_BBPPID" style="outline:none;" dir="auto" contenteditable="false"> <div name="BB10" id="BB10_response_div_BBPPID" dir="auto" style="width:100%;"> The Focus module was working well in the nominal case, but not when running the in-focus procedure, when the capture module suspended and received a guiding deviation restart. This is the issue we have been tackling during the last months, which caused so many regressions. </div> <div id="blackberry_signature_BBPPID" name="BB10" dir="auto"> <div id="_signaturePlaceholder_BBPPID" name="BB10" dir="auto"><p dir="ltr">eric.dejouhanet@gmail.com - https://astronomy.dejouha.net</p></div> </div></div><div id="_original_msg_header_BBPPID" dir="auto"> <table width="100%" style="border-spacing: 0px; display: table; outline: none;" contenteditable="false"><tbody><tr><td colspan="2" style="padding: initial; font-size: initial; text-align: initial;"> <div style="border-right: none; border-bottom: none; border-left: none; border-image: initial; border-top: 1pt solid rgb(181, 196, 223); padding: 3pt 0in 0in; font-family: Tahoma, "BB Alpha Sans", "Slate Pro"; font-size: 10pt;"> <div id="from"><b>De:</b> mutlaqja@ikarustech.com</div><div id="sent"><b>Envoyé:</b> 8 février 2021 11:42</div><div id="to"><b>À:</b> eric.dejouhanet@gmail.com</div><div id="cc"><b>Cc:</b> kstars-devel@kde.org</div><div id="subject"><b>Objet:</b> Re: Critical Focus module bug</div></div></td></tr></tbody></table> <br> </div><!--start of _originalContent --><div name="BB10" dir="auto" style="background-image: initial; line-height: initial; outline: none;" contenteditable="false"><div dir="ltr">Focus module was working quite well in 3.5.1 and before, but I think all the changes since then have introduced this regression.<div><br clear="all"><div><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>--</div><div>Best Regards,<br>Jasem Mutlaq<br></div><div><br></div></div></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 8, 2021 at 1:41 PM Jasem Mutlaq <<a href="mailto:mutlaqja@ikarustech.com">mutlaqja@ikarustech.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb( 204 , 204 , 204 );padding-left:1ex"><div dir="ltr">Hello Eric,<div><br></div><div>Actually, this has to do with Focus::checkStopFocus() ... IIRC, this was added by Hy to prevent some crash when doing HFR calculations?</div><div><br clear="all"><div><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div>--</div><div>Best Regards,<br>Jasem Mutlaq<br></div><div><br></div></div></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 8, 2021 at 1:37 PM Eric Dejouhanet <<a href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb( 204 , 204 , 204 );padding-left:1ex"><div style="background-color:rgb( 255 , 255 , 255 )"><div id="gmail-m_-765502539269884070gmail-m_7105172499519439327response_container_BBPPID" style="outline:none" dir="auto"> <div id="gmail-m_-765502539269884070gmail-m_7105172499519439327BB10_response_div_BBPPID" dir="auto" style="width:100%"> Yes this is the point of one of my draft MRs awaiting testing in the obs. The autofocus / in focus is restarting until the retries have been exceeded. The module is a mess of parallel management of ui and errors and we're slowly getting through. </div> <div id="gmail-m_-765502539269884070gmail-m_7105172499519439327response_div_spacer_BBPPID" dir="auto" style="width:100%"> <br></div> <div id="gmail-m_-765502539269884070gmail-m_7105172499519439327blackberry_signature_BBPPID" dir="auto"> <div id="gmail-m_-765502539269884070gmail-m_7105172499519439327_signaturePlaceholder_BBPPID" dir="auto"><p dir="ltr"><a href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a> - <a href="https://astronomy.dejouha.net">https://astronomy.dejouha.net</a></p></div> </div></div><div id="gmail-m_-765502539269884070gmail-m_7105172499519439327_original_msg_header_BBPPID" dir="auto"> <table width="100%" style="border-spacing:0px;display:table;outline:none"><tbody><tr><td colspan="2"> <div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb( 181 , 196 , 223 );padding:3pt 0in 0in;font-family:'tahoma' , 'bb alpha sans' , 'slate pro';font-size:10pt"> <div id="gmail-m_-765502539269884070gmail-m_7105172499519439327from"><b>De:</b> <a href="mailto:mutlaqja@ikarustech.com">mutlaqja@ikarustech.com</a></div><div id="gmail-m_-765502539269884070gmail-m_7105172499519439327sent"><b>Envoyé:</b> 8 février 2021 11:35</div><div id="gmail-m_-765502539269884070gmail-m_7105172499519439327to"><b>À:</b> <a href="mailto:kstars-devel@kde.org">kstars-devel@kde.org</a></div><div id="gmail-m_-765502539269884070gmail-m_7105172499519439327cc"><b>Cc:</b> <a href="mailto:eric.dejouhanet@gmail.com">eric.dejouhanet@gmail.com</a></div><div id="gmail-m_-765502539269884070gmail-m_7105172499519439327subject"><b>Objet:</b> Critical Focus module bug</div></div></td></tr></tbody></table> <br> </div><div dir="auto" style="outline:none"><div dir="ltr">Hello Eric,<div><br></div><div>Please check the focus module, now if you click "Stop" when autofocus is running, it just keeps going. I will check from my side, but I believe it's due to your latest changes to the module. It even restarts on its own after 20-30 secs after I clicked STOP!</div><div><br clear="all"><div><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div>--</div><div>Best Regards,<br>Jasem Mutlaq<br></div><div><br></div></div></div></div></div></div></div></div>
</div></div></blockquote></div>
</blockquote></div>
<!--end of _originalContent --></div></body></html>