<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126452/">https://git.reviewboard.kde.org/r/126452/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Decembrie 29th, 2015, 9:40 a.m. UTC, <b>Akarsh Simha</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please note that I'm making heavy backward-compatible changes to Alt vs Time plot widget right now, for use in the Observation Planner, mostly concerning the gradients. However, since the gradient has not been ported, I don't think there is anything that needs to be reworked at the moment.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I understand. I will focus on the other TODOs and leave the gradient at the end.</p></pre>
<br />
<p>- Raphael</p>
<br />
<p>On Decembrie 21st, 2015, 4:10 p.m. UTC, Raphael Cojocaru wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KStars and Jasem Mutlaq.</div>
<div>By Raphael Cojocaru.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2015, 4:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Improve Altitude vs. Time tool</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with various SkyObjects.
I implemented the Altitude vs. Time tool with QCustomPlot library. Now, the Zoom and Pan features are ready for use.
I had to rewrite some pieces of code for: the computing method needed for drawing the graph, the method needed for drawing the previous curves with red colour, the method needed for cleaning the graph ( removing all curves ).
Because I changed the KPlotWidget into a QCustomPlot Widget, there are some lines of code that can't be used anymore. I marked those lines with TODO tag, in order to find a way to solve them.
I attach here a video presentation of the result: https://www.youtube.com/watch?v=FuZEE0341sU</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/tools/altvstime.cpp <span style="color: grey">(6863c47)</span></li>
<li>kstars/tools/altvstime.ui <span style="color: grey">(2cdda14)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126452/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>