<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119010/">https://git.reviewboard.kde.org/r/119010/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 29th, 2014, 2:18 p.m. MSK, <b>Alexander Wolf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you for review. Could you, please, commit? I do not have commit rights.</pre>
<br />
<p>- Vadim</p>
<br />
<p>On June 29th, 2014, 2:15 p.m. MSK, Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated June 29, 2014, 2:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KStars uses isnan() at a few places. Unfortunately, it uses isnan() from plain C that looks like picked up by accident on some systems (while it should not be, in general). This breaks compilation on other conformant systems, like OpenBSD, which try to not leak symbols without explicit request.
The right way is to use std::isnan() from <cmath>. It's already done in kstars/skyobjects/ksmoon.cpp, but few other files need fixing.
Please note that I do not have commit rights at KDE repos.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OpenBSD/i386-CURRENT, KDE 4.13 (the affected code wasn't changed in KStars master branch).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/skycomponents/asteroidscomponent.cpp <span style="color: grey">(e173145)</span></li>
<li>kstars/skycomponents/cometscomponent.cpp <span style="color: grey">(e3b6540)</span></li>
<li>kstars/skyobjects/starobject.cpp <span style="color: grey">(ca0400d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119010/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>