<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116965/">https://git.reviewboard.kde.org/r/116965/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 6th, 2014, 10:17 p.m. UTC, <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works nicely, but I think it would be better to keep zooming behavior of SSV consistent with skymap - where normally the zoom is operating in coarse mode, but you can lower the zooming step by holding the CTRL key. In your patch, it's the other way around.</pre>
</blockquote>
<p>On April 7th, 2014, 4:39 a.m. UTC, <b>Vijay Dhameliya</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually zoom operating is so slow i.e. if user wants to zoom enough to view only two inner most orbits it cost many clicks or mouse wheel roles which is bit annoying, at the same time user should be able to lower zooming step like you mentioned, so I would suggest to make use of two different key i.e. Shift and Ctrl to increase and decrease zoom step respectively. What is your opinion about this idea ?</pre>
</blockquote>
<p>On April 7th, 2014, 8:11 a.m. UTC, <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Of course, this is possible. But how will you communicate this to the user? CTRL + mouse wheel is common, and I think that it would be a good idea to stick to this pattern.
Having said that, I agree that the zoom speed right now is far too slow.</pre>
</blockquote>
<p>On April 7th, 2014, 8:25 a.m. UTC, <b>Vijay Dhameliya</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">True, using Shift will be of no use as user wont know about it. So should I change the expression which increase the speed such that it decrease the same ?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, just make it other way around and it will be OK.</pre>
<br />
<p>- Rafal</p>
<br />
<p>On March 21st, 2014, 9:51 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated March 21, 2014, 9:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently zoom in/out factor is set constant which is very small so zoom in/out works very slowly, i.e. user have to keep rolling mouse wheel for long to get zoom enough to observe single planet.
This features allows user to do quick zoom in/out by pressing ctrl + wheel/+-keys. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing has done for following use cases:
1) Zoom in/out by pressing +/- continuously till it can not zoom in/out furthermore
2) Zoom in/out by rolling rolling wheel up/down continuously till it can not zoom in/out furthermore
3) Zoom in/out by pressing Ctrl + +/- continuously till it can not zoom in/out furthermore
4) Zoom in/out by rolling Ctrl + rolling wheel up/down continuously till it can not zoom in/out furthermore
5) Zoom in/out by pressing +/- step by step till it can not zoom in/out furthermore
6) Zoom in/out by rolling rolling wheel up/down step by step till it can not zoom in/out furthermore
7) Zoom in/out by pressing Ctrl + +/- step by step till it can not zoom in/out furthermore
8) Zoom in/out by rolling Ctrl + rolling wheel up/down step by step till it can not zoom in/out furthermore
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/tools/pvplotwidget.h <span style="color: grey">(ef90ace)</span></li>
<li>kstars/tools/pvplotwidget.cpp <span style="color: grey">(b8a8b30)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116965/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>