<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113325/">http://git.reviewboard.kde.org/r/113325/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship it!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113325/diff/5/?file=212576#file212576line87" style="color: black; font-weight: bold; text-decoration: underline;">kstars/skyobjects/ksmoon.h</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">updateMag</span><span class="p">()</span> <span class="p">{</span> <span class="n">findMagnitude</span><span class="p">(</span><span class="nb">NULL</span><span class="p">);</span> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This isn't related to your code, but I have no idea why findMagnitude() is private...</pre>
</div>
<br />
<p>- Rafal Kulaga</p>
<br />
<p>On November 11th, 2013, 9:38 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Akarsh Simha, Rafal Kulaga, and Rishab Arora.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2013, 9:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Strange thing is findMagnitude() function from moon object is never called in Kstars even though its implementation is correct and yields correct magnitude of moon according to wikipedia.
The public method updateMag() can be called from anywhere in Kstars to set magnitude in Moon object and it is called from class DetailDialog to saw magnitude in detail dialog widget.
Many skyobject like Saturn and some stars the magnitude is always in hundredth decimal place so it is better to set magnitude to hundredth decimal place in class DetailDialog. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Integer digits of magnitude being calculated matches to that given on Wikipedia for all phases </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/dialogs/detaildialog.cpp <span style="color: grey">(7eabb9c)</span></li>
<li>kstars/skyobjects/ksmoon.h <span style="color: grey">(559d203)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113325/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/e2e4721f-607b-40c4-b3aa-f2787002a873__moon_detail_before.png">moon_detail_before.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/13d80941-59f1-4ab5-83f4-858153f3263a__moon_detail_after.png">moon_detail_after.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>