<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113520/">http://git.reviewboard.kde.org/r/113520/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6a5a54de422d8eea01c8ca791809a2839e757515 by Jasem Mutlaq to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On October 31st, 2013, 3:30 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Samikshan Bairagya, Henry de Valence, and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2013, 3:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-> Problem as pointed by James Bowlin:
The problem is that the lower limit of star density available through the mouse-wheel is now very high. It is much higher than what can be seen with the naked eye and is much higher than the default star density when KStars starts for the first time.
So now if anyone uses <Alt> + <Mouse-Wheel> they will be stuck with a fairly high star density and the only way to get it back to how it started is to go to Preferences --> Configure KStars! For most people, the control is completely broken because it only increases the star density and never decreases it.
-> Fixed:
Set upper limit and lower limit of stars density such that it vary from least possible to highest possible value.
Set magnification factor under <Ctrl> and <Shift> such that stars density increase/decrease linearly rather than exponentially.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested -> Gives expected results</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/skymapevents.cpp <span style="color: grey">(9cfbb8d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113520/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>