<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113438/">http://git.reviewboard.kde.org/r/113438/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 28th, 2013, 5:58 a.m. UTC, <b>Henry de Valence</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">IMO, there should generally be braces for non-trivial if-statements.
Also, would it be better to instead change KSComet so that it sets the magitude returned by mag() to the correct value, instead of doing a workaround here? That would fix the problem for other users of KSComet, too.</pre>
</blockquote>
<p>On October 28th, 2013, 12:14 p.m. UTC, <b>Vijay Dhameliya</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually to set magnitude returned by mag() we need to call setMag() from KSComet but since setMag() is protected we can not call it, and other way to set is setting float variable sortMagnitude = M1 which is also not possible since sortMagnitude is private so we are left with only one option i.e. to use getTotalMagnitudeParameter() whenever required </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Braces added :)</pre>
<br />
<p>- Vijay</p>
<br />
<p>On October 28th, 2013, 12:14 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2013, 12:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326647">326647</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug:
->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN which causes crashes while zooming on KSComet object.
Fixing:
-> Drawing KSComet on the basis of Total Magnitude Parameter</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug fixed - No more crashing </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/dialogs/detaildialog.cpp <span style="color: grey">(efda624)</span></li>
<li>kstars/skycomponents/cometscomponent.cpp <span style="color: grey">(395c856)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113438/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>