<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106658/">http://git.reviewboard.kde.org/r/106658/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Rafal Kulaga and Aleksey Khudyakov.</div>
<div>By Akarsh Simha.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To reduce confusion and increase clarity, define three new coordinate-setting methods for SkyPoint, and modify the existing one so that it has a mandatory epoch argument.
Earlier, there was only one method called set(RA, Dec) that would set both (RA0, Dec0) and (RA, Dec). This must be handled with care. Instead, the new methods set only the valid data, and invalidate the other data. This might not be very useful in itself, but the clarity it adds is useful. Just a plain "set" needs an additional epoch argument, and uses deprecess() to set the RA0 and Dec0 correctly. The explicitness in using setCurrent, setJ2000 or setBoth is advantageous.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A basic run of KStars rendered the SkyMap seemingly fine. The use of slotDSS() gave correct results for September 2012.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/dialogs/focusdialog.cpp <span style="color: grey">(c506c90)</span></li>
<li>kstars/projections/equirectangularprojector.cpp <span style="color: grey">(37475a1)</span></li>
<li>kstars/projections/projector.cpp <span style="color: grey">(18c6489)</span></li>
<li>kstars/skycomponents/customcatalogcomponent.cpp <span style="color: grey">(83159d4)</span></li>
<li>kstars/skymap.cpp <span style="color: grey">(e0c3194)</span></li>
<li>kstars/skyobjects/skypoint.h <span style="color: grey">(c3549a3)</span></li>
<li>kstars/skyobjects/skypoint.cpp <span style="color: grey">(646b949)</span></li>
<li>kstars/tools/obslistwizard.cpp <span style="color: grey">(e02a490)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106658/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>