<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104392/">http://git.reviewboard.kde.org/r/104392/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This might be a bit slower, but it should not cause a significant overhead because the Observing List is seldom larger than a few 100 objects. Also, the code looks much much cleaner. Ship it!</pre>
<br />
<p>- Akarsh</p>
<br />
<p>On March 23rd, 2012, 10:20 p.m., Rishab Arora wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars.</div>
<div>By Rishab Arora.</div>
<p style="color: grey;"><i>Updated March 23, 2012, 10:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cause: In SkyGLPainter::drawObservingList, for each point there were 6 coordinates added but 'i' was incremented one. Changing ++i to i+=6 fixes that but the texture is replaced by a blue box at high zoom.
Solution: I used drawTexturedRectangle which is already being used to draw planets to draw the observation markers. Was the old method implemented with a different design in mind?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Repeated steps in bug description. No problems found.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=296627">296627</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/skyglpainter.cpp <span style="color: grey">(2a74af9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104392/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104392/s/488/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/23/corrected_400x100.png" style="border: 1px black solid;" alt="Corrected markers" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>