<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104403/">http://git.reviewboard.kde.org/r/104403/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Rafal Kulaga and Akarsh Simha.</div>
<div>By Samikshan Bairagya.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Request to review local 'sok' branch before merging it to 'master'.
Features added:
1. Notification for supernovae updates.
2. Page for supernovae options in KStars options.
3. Supernovae in OpenGL backend.
Review required on these points:
1. Check if the supernova icon is visible on the view toolbar and on KStars options window.
2. Check if bug #293183 is being generated.
3. Rendering of supernovae in OpenGL backend. Are the plus signs distorted?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Tested page for supernova options for bug #293183, for all projections.
2. No bugs found for supernova updates notification.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/CMakeLists.txt <span style="color: grey">(dd733ee)</span></li>
<li>kstars/data/scripts/supernova_updates_parser.py <span style="color: grey">(f3ec1bd)</span></li>
<li>kstars/icons/hi22-action-kstars_supernovae.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/icons/hi32-action-kstars_supernovae.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/icons/hi48-action-kstars_supernovae.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/icons/hi64-action-kstars_supernovae.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/kstars.h <span style="color: grey">(8ac71f5)</span></li>
<li>kstars/kstars.cpp <span style="color: grey">(e833720)</span></li>
<li>kstars/kstars.kcfg <span style="color: grey">(395bd94)</span></li>
<li>kstars/kstarsactions.cpp <span style="color: grey">(ba7018a)</span></li>
<li>kstars/kstarsdcop.cpp <span style="color: grey">(d1887d6)</span></li>
<li>kstars/kstarsui-indi.rc <span style="color: grey">(c9ba3c1)</span></li>
<li>kstars/kstarsui-win.rc <span style="color: grey">(6e42c6c)</span></li>
<li>kstars/kstarsui.rc <span style="color: grey">(9ee4b0e)</span></li>
<li>kstars/options/opssupernovae.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/options/opssupernovae.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/options/opssupernovae.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skycomponents/notifyupdatesui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skycomponents/notifyupdatesui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skycomponents/notifyupdatesui.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skycomponents/skymapcomposite.cpp <span style="color: grey">(1b8beb6)</span></li>
<li>kstars/skycomponents/supernovaecomponent.h <span style="color: grey">(ab824c6)</span></li>
<li>kstars/skycomponents/supernovaecomponent.cpp <span style="color: grey">(5c3c8bb)</span></li>
<li>kstars/skyglpainter.cpp <span style="color: grey">(2a74af9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104403/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104403/s/491/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/25/notifyNewSup2_400x100.png" style="border: 1px black solid;" alt="Notification of supernova updates." /></a>
<a href="http://git.reviewboard.kde.org/r/104403/s/492/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/25/SupernovaOptions_400x100.png" style="border: 1px black solid;" alt="Supernova options" /></a>
<a href="http://git.reviewboard.kde.org/r/104403/s/493/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/25/Supernova_ViewToolbar_400x100.png" style="border: 1px black solid;" alt="Toggle supernovae from view toolbar" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>