<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102091/">http://git.reviewboard.kde.org/r/102091/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks a lot for your effort!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102091/diff/2/?file=29970#file29970line17" style="color: black; font-weight: bold; text-decoration: underline;">kstars/skyobjects/supernova.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Supernova::Supernova(dms ra, dms dec, QString& date ,float m, const QString& serialNo,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">//bool Supernova::loadData() {}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make sure you remove all commented code, please.
kDebug should be fine to leave uncommented with relevant remarks :).</pre>
</div>
<br />
<p>- Victor</p>
<br />
<p>On July 26th, 2011, 7:12 a.m., Samikshan Bairagya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Victor Carbune, Rafal Kulaga, and Akarsh Simha.</div>
<div>By Samikshan Bairagya.</div>
<p style="color: grey;"><i>Updated July 26, 2011, 7:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This diff adds recently observed supernovae to KStars. Data is extracted from http://www.cbat.eps.harvard.edu/lists/RecentSupernovae.html using a python script.
Data is stored in a CSV format. The supernovae are drawn on the skymap as small orange plus signs. Also Supernovae maybe found out by name from the Find
Object dialog.box. I have yet to write the SkyGLPainter::drawSupernova() method.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing has been done with all colour schemes and in QPainter backend.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/CMakeLists.txt <span style="color: grey">(0c335b6)</span></li>
<li>kstars/colorscheme.cpp <span style="color: grey">(9d669a1)</span></li>
<li>kstars/data/chart.colors <span style="color: grey">(5515c1b)</span></li>
<li>kstars/data/classic.colors <span style="color: grey">(31e6706)</span></li>
<li>kstars/data/moonless-night.colors <span style="color: grey">(c1d3b06)</span></li>
<li>kstars/data/night.colors <span style="color: grey">(a31f69e)</span></li>
<li>kstars/kstars.h <span style="color: grey">(6516f9e)</span></li>
<li>kstars/kstars.kcfg <span style="color: grey">(6d088d7)</span></li>
<li>kstars/kstarsactions.cpp <span style="color: grey">(e917cac)</span></li>
<li>kstars/kstarsdata.cpp <span style="color: grey">(2303c5f)</span></li>
<li>kstars/kstarsinit.cpp <span style="color: grey">(7f4471e)</span></li>
<li>kstars/skycomponents/skymapcomposite.h <span style="color: grey">(adf496d)</span></li>
<li>kstars/skycomponents/skymapcomposite.cpp <span style="color: grey">(82fef8a)</span></li>
<li>kstars/skycomponents/supernovaecomponent.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skycomponents/supernovaecomponent.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skyglpainter.h <span style="color: grey">(2aa8d87)</span></li>
<li>kstars/skyglpainter.cpp <span style="color: grey">(655d2c7)</span></li>
<li>kstars/skyobjects/skyobject.h <span style="color: grey">(3a6122f)</span></li>
<li>kstars/skyobjects/supernova.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skyobjects/supernova.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skypainter.h <span style="color: grey">(1340568)</span></li>
<li>kstars/skyqpainter.h <span style="color: grey">(df7cc9b)</span></li>
<li>kstars/skyqpainter.cpp <span style="color: grey">(87719b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102091/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>