<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101650/">http://git.reviewboard.kde.org/r/101650/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars.</div>
<div>By Samikshan Bairagya.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch is dirty now. Will look into it. This patch fixes the magnitude parameter of observable comets by using a different formula altogether.
T-Mag = M1 + 5*log10(rearth) + k1*log10(rsun). Comets for which data are not available will have abnormal magnitudes of 99.
For formula refer: http://ssd.jpl.nasa.gov/horizons.cgi
Changed CometsComponent::updateDataFile() to store the k1,k2 parameters as well in the comets.dat file
Changed CometsComponent::loadData() to load M1, M2, K1, K2 parameters as well. Also if M1, M2, K1, K2 data are not available set abnormal values as default.
Changed KSComet.h and KSComet.cpp to accept M1, M2, K1, K2 parameters as well. Also modified KSComet::findMagnitude() to use the above formula.
Changed setMag() function in SkyObject.h so that for any magnitudes >=30 abnormally high value(99) is set. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested for various comets.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/dialogs/detaildialog.cpp <span style="color: grey">(3d669ef)</span></li>
<li>kstars/skycomponents/cometscomponent.cpp <span style="color: grey">(4a2851b)</span></li>
<li>kstars/skyobjects/kscomet.h <span style="color: grey">(5a858ee)</span></li>
<li>kstars/skyobjects/kscomet.cpp <span style="color: grey">(e665c70)</span></li>
<li>kstars/skyobjects/skyobject.h <span style="color: grey">(6f6a061)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101650/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>