Hi Alexey,<br><br>The problem with reusing the dialogs/detaildialog.[cpp,h] is that DetailDialog is derived from KPageDialog and the face type has been set to *Tabbed* and the options available for the face types are the following:<br>
<br>~/kde/src/KDE/kdelibs/kdeui/paged/kpagedialog.h:<br>ššš enum FaceType<br>ššš {<br>ššššš Autošš = KPageView::Auto,<br>ššššš Plainš = KPageView::Plain,<br>ššššš Listšš = KPageView::List,<br>ššššš Treešš = KPageView::Tree,<br>
ššššš Tabbed = KPageView::Tabbed<br>ššš };<br><br>Although, I liked this DetailDialog very much, in that it is being more informative, the tabbed face type limits it from being reused for showing details about multiple objects selected from a rectangle.<br>
<br>Rgds<br>-Abhi<br><br><br><div class="gmail_quote">On Wed, Jan 27, 2010 at 3:48 AM, Khudyakov Alexey <span dir="ltr"><<a href="mailto:alexey.skladnoy@gmail.com">alexey.skladnoy@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
÷ ÓÏÏÂÝÅÎÉÉ ÏÔ óÒÅÄÁ 27 ÑÎ×ÁÒÑ 2010 00:37:08 Abhijit Apte ÎÁÐÉÓÁÌ:<br>
<div class="im">> Hi,<br>
><br>
> I've now implemented the things which I mentioned in my previous mail (pl.<br>
> apply the patch attached with this mail).<br>
> 1) Multicolumnar display of objects selected in rectangle<br>
> 2) To center a object selected from the list (done by double clicking on<br>
> object list).<br>
><br>
<br>
</div>Hi. Thanks a lot for your work.<br>
<br>
This is not a review or anything like that just a quick glance at code and<br>
screenshots. I feel that adding new dialogs isn't really good idea. It put<br>
more burden on user. He have to remember more dialogs, he may be forced to<br>
jump between dialogs to accomplish task, forced to open multiple dialogs at<br>
once. <br></blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Also details dialog have similar problem (to a degree). It allow to select<br>
only one object at once. However objects on the sky tend to overlap or to be<br>
very close together. Consider star in a nebula as example. Sometimes it's<br>
difficult to select right object. Probable solution is to allow user to chose<br>
from all object in some region. Say 10px in size.<br>
<br>
These tasks seem very closely related. Maybe they could be merged into same<br>
functionality. Comments are welcome.<br>
<br>
Hopefully I'll be able to review patch and elaborate on matter above sometime<br>
at the weekends.<br>
_______________________________________________<br>
Kstars-devel mailing list<br>
<a href="mailto:Kstars-devel@kde.org">Kstars-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kstars-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kstars-devel</a><br>
</blockquote></div><br>