<div>Hi James!</div>
<div> </div>
<div>Great, I can't wait to have a look. Unfortunatly, I'm out of
town and won't be able to test the patch until Dec. 3rd at least.
I can say that the problem you are seeing is simply caused by a missing
call to EquatorialToHorizontal() on each new constellation name
point. Your fix (always update both sets of constellation names)
works, but it would probably be better to just do a loop over the
newly-active list and call that function when changing lists.<BR></div>
<div>I'll write more later, but let me just say thanks a lot for the
contribution, and I hope you continue to help us out :)</div>
<div> </div>
<div>regards,</div>
<div>Jason<BR></div>
<BLOCKQUOTE style="PADDING-LEFT: 8px; MARGIN-LEFT: 8px; BORDER-LEFT:
blue 2px solid"><BR>-------- Original Message --------<BR>Subject: Re:
[Kstars-devel] Menu Support for HA Rey Constellations<BR>From: James
Bowlin <bowlin@mindspring.com><BR>Date: Sat, November 26, 2005
1:57 pm<BR>To: KStars Development Mailing List
<kstars-devel@kde.org><BR><BR>On Thursday 24 November 2005 01:58
am, Jason Harris wrote:<BR>> Sounds great. I basically agree
with this approach, go for it :)<BR><BR>Okay, it's done. The
patch file is large (90k+) so I am going to<BR>email it to Jason
instead of posting it here. Most of the bulk is<BR>from the new
clines-rey.dat and cnames-rey.dat files. If anyone<BR>else wants
it, just let me know. I will be glad to send it to you.<BR>Please
remember that this patch is for the 3.5 branch that I
recently<BR>checked out from the KDE SVN repository.<BR><BR>When I
added the hidden star names I sped up the reading in of the<BR>clines
data by a factor of almost 10x. The original code searched<BR>a
list of 13,000+ named objects for each line in clines*.dat.
I<BR>created a new list of just named stars which has only 1,600
or so<BR>entries. That list can be destroyed after all the cline
data files<BR>have been read, but I don't know how to do this.
<BR><BR>I noticed a strange bug with the constellation names.
The bug occurs<BR>the first time I switch between the Rey names
and either the Latin<BR>names or the abbreviated names. After
switching the names in the<BR>Guides setup menu and then zooming or
moving the skymap to cause a<BR>redraw, all the constellation names are
piled up at one spot. I<BR>think this spot is always just above
the horizon over the "N" marking<BR>North. If I wait about 30
seconds and then cause another redraw,<BR>the names then all jump to
their proper positions. I cannot imagine<BR>how the changes I
made could directly cause this behavior.<BR><BR>I've tracked this bug
down to the SkyMap::getXY() method inside of<BR>skymap.cpp.
When the bug occurs, it gets the proper input from my<BR>lists
but produces a constant output of the one fixed point. Here<BR>is
an example:<BR><BR>Name ra
dec x y <BR>---------
-------- -------- --- --<BR>ANDROMEDA:
0.715585 0.349066 108 68<BR>ANTLIA:
-0.558505 2.61799 108 68<BR>APUS:
-1.32645 4.18879 108 68<BR><BR>The ra and dec
are those of the object sent to getYX(), the x, y values<BR>are from the
output of that method. After 30 seconds the same ra and<BR>dec
values produce the correct x, y values.<BR><BR><BR>I am not certain
that the new files (cnames-rey.dat and clines-rey.dat)<BR>will be
installed properly by a "make install". I made what seemed
to<BR>be the right changes to kstars.kdevprj by copying what was
already<BR>there for clines.dat and cnames.dat. I was impressed
by how clever<BR>"make install" is. For example, if I change
hip001.dat and then<BR>run "make install", it knows to install that
file, but it doesn't<BR>re-install all the data files that haven't
changed. The two new<BR>files I created don't work this way so I
have to manually copy them<BR>to the proper subdirectory under
$KDEDIR.<BR><BR>I double checked the star names I added that were
needed to complete<BR>the Rey constellations. These are in the
patch. I am still working<BR>on adding as many star names as I
can find to hip001.dat. I can<BR>put these changes in a separate
patch file (as well as a combined<BR>patch file) once I am done making
and checking them.<BR><BR>-- <BR>Peace,
James<BR>_______________________________________________<BR>Kstars-devel
mailing
list<BR>Kstars-devel@kde.org<BR>https://mail.kde.org/mailman/listinfo/kstars-devel
</BLOCKQUOTE>