Kstars 3.6.0 MacOS find Object crash

[Robert Lancaster]

Ok I did some more testing.

This commit is when the Find Dialog broke when running KStars on MacOS by double clicking the app:

https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9 <https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9>

I think that is the one you were hoping was not the one.  I still don’t know why it broke it though.  Every time I run it from terminal or qt creator there is no problem.  It is just when running it by double clicking that is the problem.

Note that I did test playing with the environment variables in qt creator and that seemed to have no effect.  And it also didn’t seem to matter whether kstars was packaged up or not, so it doesn’t seem to be a packaging issue.

> On Aug 16, 2022, at 2:11 PM, Akarsh Simha <akarshsimha at gmail.com> wrote:
> 
> If I am to blame for this, the parallelism introduced in the asynchronous find dialog is my suspect, rather than the comet regex (which was actually Hy and not me). The regex seems unlikely to cause the erratic behavior Robert is observing where it runs fine under a debugger.
> 
> But if it works fine when running KStars from a command line, that probably exonerates me and Hy, and is likely an environment issue like Robert points out!
> 
> Regards
> Akarsh
> 
> 
> On Tue, Aug 16, 2022 at 07:28 Robert Lancaster <rlancaste at gmail.com <mailto:rlancaste at gmail.com>> wrote:
> Hey guys,
> 
> I just got back from my two week trip to the Southwest.  Yesterday I resolved the issue with building a dmg with my script, so now I can build DMGs that will work with older Macs and have all the features we want in the dmg.  
> 
> Next we can look into this Find Dialog bug.  I did some experiments today and I found that if I run kstars from the command line or in a debugger, the find dialog works fine, but when running the app by double clicking it crashes when you first access the find dialog.  This seems to me to indicate an environment issue, like maybe an issue with environment variables or maybe a link to a library that isn’t properly in the app.  I will check further.
> 
> Thanks,
> 
> Rob
> 
>> On Aug 13, 2022, at 6:09 AM, John Evans <john.e.evans.email at gmail.com <mailto:john.e.evans.email at gmail.com>> wrote:
>> 
>> I have the same problem with 3.6.0. Crashes everytime the find object dialog is invoked (button, keyboard, etc.)
>> 
>> Works great when I run it in debug in Qt though.
>> 
>> Workaround is to use the skymap and click on the object you want. In the scheduler enter some text in the object field (doesn't matter what) and hit the + to use sky coordinates from the map.
>> 
>> On Sat, 13 Aug 2022 at 10:05, Akarsh Simha <akarshsimha at gmail.com <mailto:akarshsimha at gmail.com>> wrote:
>> 
>> 
>> On Sat, Aug 13, 2022 at 01:27 Peter Amerl <pvamerl at gmail.com <mailto:pvamerl at gmail.com>> wrote:
>> Hi All, 
>> Has anyone else experienced an immediate crash when searching for objects on a Mac using the Apple-f key combination?
>> I can confirm that it has worked in the past without a crash. Neither Ctrl-f, nor selecting it from the menu appears to work for me at this time. 
>> The Crash trace is appended in the zip if anyone wants to have a look.
>> 
>> Hi Peter
>> 
>> When you say it worked in the past, could you provide the exact version / git commit, and also your current version / git  commit that has the bug? I made several changes to the Find Dialog in the most recent version, notably performing asynchronous database queries through another thread. It never crashed on my Linux system. Also curious if someone else can reproduce it on MacOS or if it is unique to your system.
>> 
>> Regards
>> Akarsh
>> 
>> 
>> Cheers, 
>> Peter 
>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20220817/30e54aba/attachment-0001.htm>