Bad commit, please revert

[Jasem Mutlaq]

I also submitted MR
https://invent.kde.org/education/kstars/-/merge_requests/237

Temporary files are a relic so the MR removes them completely. Let me know
if you can spot any issues, I ran all the tests for capture and all went
fine. ekos_capture_count almost passed but it crashed, and it used to crash
before this MR as well.

--
Best Regards,
Jasem Mutlaq



On Mon, Mar 8, 2021 at 11:39 AM Wolfgang Reissenberger <
sterne-jaeger at openfuture.de> wrote:

> Aaah, very good, that explains the behavior. I experienced the same
> problem and had the impression that the image got downloaded, but it
> disappeared shortly after.
>
> Am 08.03.2021 um 09:21 schrieb Hy Murveit <murveit at gmail.com>:
>
> Jasem and I worked on this, and Jasem has submitted a fix.
>
> https://invent.kde.org/education/kstars/-/commit/6a45cb448927a66b4d7e40b737306c8d25c28f58
> As far as I can tell, the fix corrects the issue I was seeing
>
> BTW, I've updated my forum post:
> https://indilib.org/forum/general/9014-fixed-latest-code-bad.html#68369
> to reflect the fix.
>
>
> On Sun, Mar 7, 2021 at 11:26 PM Jasem Mutlaq <mutlaqja at ikarustech.com>
> wrote:
>
>> Hello Hy,
>>
>> That's my commit. Any way to reproduce this bug? I just now tried taking
>> 10 flats and couldn't see any issue. Please let me know how to reproduce
>> this.
>> --
>> Best Regards,
>> Jasem Mutlaq
>>
>>
>>
>> On Mon, Mar 8, 2021 at 7:35 AM Hy Murveit <murveit at gmail.com> wrote:
>>
>>> TL;DR. I think that commit cf3d3b2f9e0559f27677e28642ab642ac2a2933d has
>>> a serious bug and needs to be reverted ASAP.
>>>
>>> I'm not sure how to do this: Jasem or Eric?
>>>
>>> Details: I was taking flats tonight with HEAD and noticed that my images
>>> weren't saved.
>>> I looked at the disk holding my imaging run from last night.  No images
>>> were saved.
>>>
>>> I searched recent git commits, checking them out and compiling and
>>> testing a small capture sequence.  It looks like the problem is  is
>>> cf3d3b2f
>>> <https://invent.kde.org/education/kstars/-/commit/cf3d3b2f9e0559f27677e28642ab642ac2a2933d>
>>>
>>> I recommend reverting that commit ASAP.
>>> Hy
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20210308/b41fa066/attachment.htm>