Bad commit, please revert

[Hy Murveit]

Jasem and I worked on this, and Jasem has submitted a fix.
https://invent.kde.org/education/kstars/-/commit/6a45cb448927a66b4d7e40b737306c8d25c28f58
As far as I can tell, the fix corrects the issue I was seeing

BTW, I've updated my forum post:
https://indilib.org/forum/general/9014-fixed-latest-code-bad.html#68369
to reflect the fix.


On Sun, Mar 7, 2021 at 11:26 PM Jasem Mutlaq <mutlaqja at ikarustech.com>
wrote:

> Hello Hy,
>
> That's my commit. Any way to reproduce this bug? I just now tried taking
> 10 flats and couldn't see any issue. Please let me know how to reproduce
> this.
> --
> Best Regards,
> Jasem Mutlaq
>
>
>
> On Mon, Mar 8, 2021 at 7:35 AM Hy Murveit <murveit at gmail.com> wrote:
>
>> TL;DR. I think that commit cf3d3b2f9e0559f27677e28642ab642ac2a2933d has a
>> serious bug and needs to be reverted ASAP.
>>
>> I'm not sure how to do this: Jasem or Eric?
>>
>> Details: I was taking flats tonight with HEAD and noticed that my images
>> weren't saved.
>> I looked at the disk holding my imaging run from last night.  No images
>> were saved.
>>
>> I searched recent git commits, checking them out and compiling and
>> testing a small capture sequence.  It looks like the problem is  is
>> cf3d3b2f
>> <https://invent.kde.org/education/kstars/-/commit/cf3d3b2f9e0559f27677e28642ab642ac2a2933d>
>>
>> I recommend reverting that commit ASAP.
>> Hy
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20210308/2ea1a31f/attachment.htm>