Scheduler end time calculation issue

[Hy Murveit]

It's do-able, of course. It's not a one-liner.
Would require code to estimate the job-abort time, similar to running
evaluateJob for a number of simulated future minutes.

IMHO, we should probably re-think the scheduler table.
It's not really that useful to give an "idealized" end-time with a warning,
since we know for sure it won't end then.
We probably should give the known interrupt time (as you were expecting)
with some kind of flag that indicates the job won't fully complete at that
time. Perhaps the thinking was that the job would pick up "tomorrow night"?
Should we indicate when it will finish tomorrow?
I'd vote for displaying tonight's interrupt time.

Hy

On Wed, Aug 18, 2021 at 10:20 PM Jasem Mutlaq <mutlaqja at ikarustech.com>
wrote:

> Thanks for looking into this Hy, it makes sense. Is the fix easy for
> the warning symbol?
>
> --
> Best Regards,
> Jasem Mutlaq
>
>
> On Thu, Aug 19, 2021 at 1:32 AM Hy Murveit <murveit at gmail.com> wrote:
> >
> > I took a quick look, and it seems that the "End Time" field in the
> scheduler job table displays the time the job "would end" if there were no
> altitude or twilight or other constraints. It does NOT display the time the
> job will be suspended because of altitude, twilight, etc.
> >
> > Looking at the tooltip for that field, it says: "A warning symbol
> indicates the altitude at completion may cause the job to abort before
> completion", which further supports my interpretation.
> >
> > If you run your job, I'll bet it will get suspended at twilight.
> >
> > Your job does show a minor bug, in that it should have gotten the
> "warning symbol", and your picture shows that it doesn't.
> >
> > It seems that warning symbol is only implemented for the minAltitude
> parameter, not for twilight, not for artificial horizon.
> > See line 566 in schedulerjob.cpp:
> >
> https://invent.kde.org/education/kstars/-/blob/master/kstars/ekos/scheduler/schedulerjob.cpp#L566
> > Instead of saying "altitudeAtStartup < minAltitude" there would need to
> be more sophisticated processing that looks at twilight, artificial horizon
> and minAltitude. I'm guessing that in your log file, you can find the
> message generated in this line
> >
> https://invent.kde.org/education/kstars/-/blob/master/kstars/ekos/scheduler/scheduler.cpp#L2466
> > that says it will be interrupted due to twilight.  It doesn't look like
> we do that computation and log message for altitude.
> >
> > Hy
> >
> >
> > On Wed, Aug 18, 2021 at 2:27 PM Jasem Mutlaq <mutlaqja at ikarustech.com>
> wrote:
> >>
> >> Hello everyone,
> >>
> >> I scheduled a job today but the end time was set at 5:20 AM whereas
> >> the twilight is 3:54 AM. What's the reason behind this discrepancy?
> >>
> >> --
> >> Best Regards,
> >> Jasem Mutlaq
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20210819/d8e08c7a/attachment.htm>