[Kstars-devel] Review Request 112879: Restring addition of null supernovae objects to supernovaecomponent list

[Vijay Dhameliya]

> On Sept. 28, 2013, 5:43 p.m., Henry de Valence wrote:
> > Do all of the supernovae with NaN coordinates have null serial numbers?
> > 
> > If so, then this looks good to me.

Yes, the serial number is null only and only when whole line is dummy and there is no entry in catalog without serial number


- Vijay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112879/#review40962
-----------------------------------------------------------


On Sept. 24, 2013, 7:35 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112879/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 7:35 p.m.)
> 
> 
> Review request for KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.
> 
> 
> Description
> -------
> 
> While loading data for supernovae, there seems error in reading file supernovae.dat  so it leads to creation of dummy supernovae object which leads to various error during run time of Kstars. So lets avoid creation of such dummy supernovae objects. 
> This fixes attached bug too.
> 
> 
> This addresses bug 322848.
>     http://bugs.kde.org/show_bug.cgi?id=322848
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/supernovaecomponent.cpp 166a3d5 
> 
> Diff: http://git.reviewboard.kde.org/r/112879/diff/
> 
> 
> Testing
> -------
> 
> Tested - Runs well
> Bug resolved permanently 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130928/362975a8/attachment.html>