These changes look great! Much more sensible. Thanks!<div><br></div><div>Minor comments:</div><div><br></div><div> -why is 'exit application' in the toolbar? The window manager already has such a button, and I've never seen it in any other apps' toolbars.</div>
<div><br></div><div> -For the sake of reducing the number of toolbar entries: Do we really want save, open, and print in the toolbar? I'm not sure. (some other apps do, others don't.)</div><div><br></div><div> -I don't think that 'shared axis box' belongs with the zoom options. Although it's not really an annotation, it is more like an annotation, than a mouse mode... maybe. </div>
<meta http-equiv="content-type" content="text/html; charset=utf-8"><div><br></div><div> -would it be better to turn the Layout Mode toggle into a radio set between the upcoming 'x zoom mode', 'y zoom mode', 'xy zoom mode' and 'layout mode'? This is what okular does in the same situation. Takes more space, but might be more clear.</div>
<div><br></div><div> -where did the tied zoom icon come from? Do you have svg source? The idea is right, but it looks sort of murky.</div><div><br></div><div> -should we re-open the bug for these comments?<br><br><div class="gmail_quote">
On Wed, Sep 22, 2010 at 5:03 PM, Nicolas Brisset <span dir="ltr"><<a href="mailto:nicolas.brisset@eurocopter.com">nicolas.brisset@eurocopter.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><a href="https://bugs.kde.org/show_bug.cgi?id=249799" target="_blank">https://bugs.kde.org/show_bug.cgi?id=249799</a><br>
<br>
<br>
</div>Nicolas Brisset <<a href="mailto:nicolas.brisset@eurocopter.com">nicolas.brisset@eurocopter.com</a>> changed:<br>
<br>
What |Removed |Added<br>
----------------------------------------------------------------------------<br>
Status|NEW |RESOLVED<br>
Resolution| |FIXED<br>
<br>
<br>
<br>
<br>
--- Comment #10 from Nicolas Brisset <nicolas brisset eurocopter com> 2010-09-22 23:03:04 ---<br>
SVN commit 1178378 by brisset:<br>
<br>
Finish the first round of menu/toolbar reorganization. This change has one very<br>
visible impact: the create actions are<br>
moved from the data manager to the "Create" menu. There was a little bit of<br>
discussion on that a while ago and it seems to be a<br>
recurrent question from users (why are they here anyway?), plus it uses up<br>
valuable screen real estate. And they were almost<br>
always hidden, which wasn't so nice.<br>
<br>
I'd suggest trying this for a while and then deciding whether we want to re-add<br>
something to the data manager. The QActions are<br>
now created from mainwindow.cpp, we can add them to a QToolBox which we export<br>
to the data manager.<br>
I'd also appreciate if a real C++ developer checked the changes. It is a bit<br>
more than shuffling around some code and I'm not<br>
100% sure of everything.<br>
<br>
For the other small points (list of recent files, x-only and y-only zoom, ...)<br>
buried in the comments of this bug, I'll create<br>
separate entries. Some icons are also waiting to be improved, but we can do<br>
that bit by bit and it is not directly the intention<br>
of this bug.<br>
<br>
BUG: 249799<br>
<br>
<br>
M +1 -94 datamanager.cpp<br>
M +0 -11 datamanager.ui<br>
M +6 -10 <a href="http://libkstapp.pro" target="_blank">libkstapp.pro</a><br>
M +26 -1 mainwindow.cpp<br>
M +4 -1 mainwindow.h<br>
A pluginmenuitemaction.cpp [License: GPL (v2+)]<br>
A pluginmenuitemaction.h [License: GPL (v2+)]<br>
<br>
<br>
WebSVN link: <a href="http://websvn.kde.org/?view=rev&revision=1178378" target="_blank">http://websvn.kde.org/?view=rev&revision=1178378</a><br>
<div><div></div><div class="h5"><br>
--<br>
Configure bugmail: <a href="https://bugs.kde.org/userprefs.cgi?tab=email" target="_blank">https://bugs.kde.org/userprefs.cgi?tab=email</a><br>
------- You are receiving this mail because: -------<br>
You are the assignee for the bug.<br>
_______________________________________________<br>
Kst mailing list<br>
<a href="mailto:Kst@kde.org">Kst@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kst" target="_blank">https://mail.kde.org/mailman/listinfo/kst</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>C. Barth Netterfield<br>University of Toronto<br>416-845-0946<br>
</div>