[Kst] extragear/graphics/kst/src/libkstapp

Eli Fidler eli at staikos.net
Mon Feb 5 18:43:07 CET 2007


SVN commit 630535 by fidler:

these unlocks are not needed.. 

fixes Barth's crash in bug 141054


 M  +0 -10     kstplugindialog_i.cpp  


--- trunk/extragear/graphics/kst/src/libkstapp/kstplugindialog_i.cpp #630534:630535
@@ -616,16 +616,6 @@
   int pitem = _w->PluginCombo->currentItem();
   KstSharedPtr<Plugin> pPtr = PluginCollection::self()->plugin(_pluginList[pitem]);
 
-  // Must unlock before clear()
-  for (KstVectorMap::Iterator i = pp->inputVectors().begin(); i != pp->inputVectors().end(); ++i) {
-    (*i)->unlock();
-  }
-  for (KstScalarMap::Iterator i = pp->inputScalars().begin(); i != pp->inputScalars().end(); ++i) {
-    (*i)->unlock();
-  }
-  for (KstStringMap::Iterator i = pp->inputStrings().begin(); i != pp->inputStrings().end(); ++i) {
-    (*i)->unlock();
-  }
   pp->inputVectors().clear();
   pp->inputScalars().clear();
   pp->inputStrings().clear();


More information about the Kst mailing list