[Kst] [Bug 91643] Date outputs need to use KCalendarSystem

[George Staikos]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=91643        




------- Additional Comments From staikos kde org  2004-10-19 19:28 -------
On Tuesday 19 October 2004 13:05, Andrew Walker wrote:
> One obvious problem is that KCalendarSystem is in KDE 3.2 and up,
> whereas many people are still using KDE 3.1. What is it that
> KCalendarSystem provides that Qt doesn't? (not in general, but
> specific to what we are trying to do here). If we're going to go to the
> trouble of ifdef'ing code then there should be a very good reason for it.

   There's no need to ifdef.  The files are of course LGPL and self-contained.  
It's maybe a dozen or so including the implementations of all the different 
calendars.  It should hook cleanly into Kst, and we just conditionally 
compile it if we need to the way KMDI is done.  Regarding KDE 3.1, if I 
remember discussions long ago, were we going to prepare to move to 3.2/3.3 
min requirement in the new year?

   What KCalendarSystem does is output the dates correctly for all KDE users.  
It is the most correct approach, which is why it was suggested from the 
start.  Do we have people from these backgrounds using Kst?  Certainly, our 
oldest bug proves that.  The non-deprecated K* classes must be preferred to 
the Qt equivalents in Kst.