[Kst] kdeextragear-2/kst/kst

George Staikos staikos at kde.org
Mon Feb 23 03:49:16 CET 2004


CVS commit by staikos: 

Finally track down a [seemingly longstanding] crash in the plugin dialog when
showing plugins that were already created.


  M +10 -9     kstplugindialog_i.cpp   1.53


--- kdeextragear-2/kst/kst/kstplugindialog_i.cpp  #1.52:1.53
@@ -169,9 +169,8 @@ void KstPluginDialogI::update(int new_in
   }
 
-  int oldPluginIndex = PluginCombo->currentItem();
   KstPluginPtr plugin = pl[Select->currentItem()];
-  KSharedPtr<Plugin> pPtr = PluginCollection::self()->plugin(_pluginList[PluginCombo->currentItem()]);
-  if( pPtr != 0 ) {  
-    int newPluginIndex = _pluginList.findIndex(pPtr->data()._name);
+
+  int oldPluginIndex = PluginCombo->currentItem();
+  int newPluginIndex = _pluginList.findIndex(plugin->plugin()->data()._name);
     bool updateCombos = (newPluginIndex != oldPluginIndex);
 
@@ -181,4 +180,6 @@ void KstPluginDialogI::update(int new_in
     }
 
+  KSharedPtr<Plugin> pPtr = PluginCollection::self()->plugin(_pluginList[PluginCombo->currentItem()]);
+  if( pPtr != 0 ) {  
     // Update input vector and scalar combos
     const QValueList<Plugin::Data::IOValue>& itable = pPtr->data()._inputs;





More information about the Kst mailing list