<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119969/">https://git.reviewboard.kde.org/r/119969/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 1st, 2014, 9:46 a.m. UTC, <b>Valentin Rusu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
</blockquote>
<p>On October 7th, 2014, 7:06 p.m. UTC, <b>Valentin Rusu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Heya, did you commit this change?</p></pre>
</blockquote>
<p>On October 8th, 2014, 8:22 a.m. UTC, <b>Alexander Volkov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can't commit, I have no contributor account.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You can ask for one by filing a bug to the sysadmin. Interested?</p></pre>
<br />
<p>- Valentin</p>
<br />
<p>On August 28th, 2014, 10:38 a.m. UTC, Alexander Volkov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KSecretService.</div>
<div>By Alexander Volkov.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2014, 10:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksecrets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ksecrets_export.h is already generated and it's preferable to use it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/api/ksecrets/ksecretsservicecollectionjobs.h <span style="color: grey">(beb6082)</span></li>
<li>src/api/ksecrets/ksecretsserviceitem.h <span style="color: grey">(d35a96e)</span></li>
<li>src/api/ksecrets/ksecretsserviceitemjobs.h <span style="color: grey">(e673485)</span></li>
<li>src/api/ksecrets/ksecretsservicemacros.h <span style="color: grey">(877353a)</span></li>
<li>src/api/ksecrets/ksecretsservicesecret.h <span style="color: grey">(d91a617)</span></li>
<li>src/api/ksecrets/ksecretsservicecodec.h <span style="color: grey">(d5edb8a)</span></li>
<li>src/api/ksecrets/ksecretsservicecollection.h <span style="color: grey">(bbc3140)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119969/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>