<div dir="ltr"><div>Hello,</div><div><br></div><div>Now I managed to compile. The load-performance-stable branch went better.</div><div>I just neede to comment a couple of lines in /RemoteControl/RemoteConnection.cpp<br></div><div><br></div><div>protocolDebug() << qPrintable(QTime::currentTime().toString(QString::fromUtf8("hh:mm:ss.zzz")))<br> << ": Received " << qPrintable(id);<br></div><div><br></div><div>But after opening the kphotoalbum (very fast, although not fully tested), the display of thumbnails is very slow, and also opening photographs (CR2 files).</div><div><br></div><div>Will test more and report it.</div><div><br></div><div>Thanks.<br></div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><br style="font-family:courier new,monospace"><span style="font-family:courier new,monospace">______________________________</span><br style="font-family:courier new,monospace"><span style="font-family:courier new,monospace">----------- Angel ------------<br><br style="font-family:courier new,monospace"></span></div></div>
<br><div class="gmail_quote">2018-06-03 15:52 GMT+02:00 Robert Krawitz <span dir="ltr"><<a href="mailto:rlk@alum.mit.edu" target="_blank">rlk@alum.mit.edu</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sun, 3 Jun 2018 09:53:29 +0200, Angel Lopez wrote:<br>
> I'm trying to compile your Load-performance brach, but I'm getting compiler<br>
> errors:<br>
> First, I got a :<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/MainWindow/<wbr>Window.cpp:1761:6:<br>
</span>> error: no declaration matches =E2=80=98void<br>
<span class="">> MainWindow::Window::<wbr>slotOptimizeThumbnails()'<br>
> void MainWindow::Window::<wbr>slotOptimizeThumbnails()<br>
> ^~~~~~~~~~<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/MainWindow/<wbr>Window.cpp:1761:6:<br>
</span>> nota: no functions named =E2=80=98void MainWindow::Window::<wbr>slotOptimizeThumbnails()'<br>
<br>
My bad. I hadn't intended to leave this in at this point. Try the<br>
load-performance-stable branch.<br>
<span class=""><br>
> I fixed that including a declaration in MainWindow.h<br>
><br>
> Now I got these errors:<br>
<br>
</span>This is probably due to the Qt version; I haven't touched anything in<br>
this area.<br>
<div class="HOEnZb"><div class="h5"><br>
> In file included from /usr/include/qt/QtCore/<wbr>qnamespace.h:43,<br>
> from /usr/include/qt/QtCore/<wbr>qobjectdefs.h:48,<br>
> from /usr/include/qt/QtCore/<wbr>qobject.h:46,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:<br>
> In member function 'void RemoteControl::<wbr>RemoteConnection::<wbr>dataReceived()':<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:52:<br>
> error: no matching function for call to 'asString(qint32&)'<br>
> << ": Received " << qPrintable(id);<br>
> ^~~~~~~~~~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qobject.h:47,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:1862:23: note: candidate: 'const QString&<br>
> QtPrivate::asString(const QString&)' <near match><br>
> inline const QString &asString(const QString &s) { return s; }<br>
> ^~~~~~~~<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:1862:23: note: conversion of argument 1<br>
> would be ill-formed:<br>
> In file included from /usr/include/qt/QtCore/<wbr>qnamespace.h:43,<br>
> from /usr/include/qt/QtCore/<wbr>qobjectdefs.h:48,<br>
> from /usr/include/qt/QtCore/<wbr>qobject.h:46,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:63:<br>
> error: invalid user-defined conversion from 'qint32' {aka 'int'} to 'const<br>
> QString&' [-fpermissive]<br>
> << ": Received " << qPrintable(id);<br>
> ^~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qobject.h:47,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:829:5: note: candidate is:<br>
> 'QString::QString(const char*)' <near match><br>
> QString(const char *ch);<br>
> ^~~~~~~<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:829:5: note: conversion of argument 1<br>
> would be ill-formed:<br>
> In file included from /usr/include/qt/QtCore/<wbr>qnamespace.h:43,<br>
> from /usr/include/qt/QtCore/<wbr>qobjectdefs.h:48,<br>
> from /usr/include/qt/QtCore/<wbr>qobject.h:46,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:63:<br>
> error: invalid conversion from 'qint32' {aka 'int'} to 'const char*'<br>
> [-fpermissive]<br>
> << ": Received " << qPrintable(id);<br>
> ^~<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:52:<br>
> error: 'QString::QString(const char*)' is private within this context<br>
> << ": Received " << qPrintable(id);<br>
> ^~~~~~~~~~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qobject.h:47,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:829:5: note: declared private here<br>
> QString(const char *ch);<br>
> ^~~~~~~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qnamespace.h:43,<br>
> from /usr/include/qt/QtCore/<wbr>qobjectdefs.h:48,<br>
> from /usr/include/qt/QtCore/<wbr>qobject.h:46,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:63:<br>
> error: invalid conversion from 'qint32' {aka 'int'} to 'const char*'<br>
> [-fpermissive]<br>
> << ": Received " << qPrintable(id);<br>
> ^~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qobject.h:47,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:829:25: note: initializing argument 1 of<br>
> 'QString::QString(const char*)'<br>
> QString(const char *ch);<br>
> ~~~~~~~~~~~~^~<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:1863:18: note: candidate: 'QString&&<br>
> QtPrivate::asString(QString&&)<wbr>' <near match><br>
> inline QString &&asString(QString &&s) { return std::move(s);<br>
> }<br>
> ^~~~~~~~<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:1863:18: note: conversion of argument 1<br>
> would be ill-formed:<br>
> In file included from /usr/include/qt/QtCore/<wbr>qnamespace.h:43,<br>
> from /usr/include/qt/QtCore/<wbr>qobjectdefs.h:48,<br>
> from /usr/include/qt/QtCore/<wbr>qobject.h:46,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:63:<br>
> error: invalid user-defined conversion from 'qint32' {aka 'int'} to<br>
> 'QString&&' [-fpermissive]<br>
> << ": Received " << qPrintable(id);<br>
> ^~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qobject.h:47,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:829:5: note: candidate is:<br>
> 'QString::QString(const char*)' <near match><br>
> QString(const char *ch);<br>
> ^~~~~~~<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:829:5: note: conversion of argument 1<br>
> would be ill-formed:<br>
> In file included from /usr/include/qt/QtCore/<wbr>qnamespace.h:43,<br>
> from /usr/include/qt/QtCore/<wbr>qobjectdefs.h:48,<br>
> from /usr/include/qt/QtCore/<wbr>qobject.h:46,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:63:<br>
> error: invalid conversion from 'qint32' {aka 'int'} to 'const char*'<br>
> [-fpermissive]<br>
> << ": Received " << qPrintable(id);<br>
> ^~<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:52:<br>
> error: 'QString::QString(const char*)' is private within this context<br>
> << ": Received " << qPrintable(id);<br>
> ^~~~~~~~~~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qobject.h:47,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:829:5: note: declared private here<br>
> QString(const char *ch);<br>
> ^~~~~~~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qnamespace.h:43,<br>
> from /usr/include/qt/QtCore/<wbr>qobjectdefs.h:48,<br>
> from /usr/include/qt/QtCore/<wbr>qobject.h:46,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:63:<br>
> error: invalid conversion from 'qint32' {aka 'int'} to 'const char*'<br>
> [-fpermissive]<br>
> << ": Received " << qPrintable(id);<br>
> ^~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qobject.h:47,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /usr/include/qt/QtCore/<wbr>qstring.h:829:25: note: initializing argument 1 of<br>
> 'QString::QString(const char*)'<br>
> QString(const char *ch);<br>
> ~~~~~~~~~~~~^~<br>
> In file included from /usr/include/qt/QtCore/<wbr>qnamespace.h:43,<br>
> from /usr/include/qt/QtCore/<wbr>qobjectdefs.h:48,<br>
> from /usr/include/qt/QtCore/<wbr>qobject.h:46,<br>
> from /usr/include/qt/QtCore/<wbr>QObject:1,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.h:22,<br>
> from<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:19:<br>
> /home/angel/src/kphotoalbum-<wbr>Load-performance/<wbr>RemoteControl/<wbr>RemoteConnection.cpp:108:52:<br>
> error: conversion to non-const reference type 'class QString&&' from rvalue<br>
> of type 'QString' [-fpermissive]<br>
> << ": Received " << qPrintable(id);<br>
> ^~~~~~~~~~<br>
> make[2]: *** [CMakeFiles/kphotoalbum.dir/<wbr>build.make:3053:<br>
> CMakeFiles/kphotoalbum.dir/<wbr>RemoteControl/<wbr>RemoteConnection.cpp.o] Error 1<br>
> make[1]: *** [CMakeFiles/Makefile2:69: CMakeFiles/kphotoalbum.dir/<wbr>all]<br>
> Error 2<br>
> make: *** [Makefile:141: all] Error 2<br>
><br>
><br>
><br>
><br>
> Now, I have no idea about what to do. Could be related to Qt version?<br>
> I'm on Arch Linux and Qt-5.11<br>
><br>
> Regards, and thanks for your efforts to make kphotoalbum even better !!!<br>
><br>
<br>
<br>
</div></div><div class="HOEnZb"><div class="h5">-- <br>
Robert Krawitz <<a href="mailto:rlk@alum.mit.edu">rlk@alum.mit.edu</a>><br>
<br>
*** MIT Engineers A Proud Tradition <a href="http://mitathletics.com" rel="noreferrer" target="_blank">http://mitathletics.com</a> ***<br>
Member of the League for Programming Freedom -- <a href="http://ProgFree.org" rel="noreferrer" target="_blank">http://ProgFree.org</a><br>
Project lead for Gutenprint -- <a href="http://gimp-print.sourceforge.net" rel="noreferrer" target="_blank">http://gimp-print.sourceforge.<wbr>net</a><br>
<br>
"Linux doesn't dictate how I work, I dictate how Linux works."<br>
--Eric Crampton<br>
</div></div></blockquote></div><br></div>