<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body style='font-family: Verdana,Geneva,sans-serif'>
<p>Hello Johannes,</p>
<p>sorry, it took me a while to find the time to compile KPA and test your patch.</p>
<p>Unfortunately I can't see any improvement. Is there anything else that I can try now that I'm able to compile KPA?</p>
<p>Manfred</p>
<p> </p>
<p>Btw. initially I did get an error when I tried to apply the patch:</p>
<p>manfred@icg-pc217:~/src/kphotoalbum$ git apply 0001-Disable-Thumbnailrequest-preemption.patch<br />0001-Disable-Thumbnailrequest-preemption.patch:18: trailing whitespace.<br />#ifdef REQUESTQUEUE_PREEMPT<br />0001-Disable-Thumbnailrequest-preemption.patch:25: trailing whitespace.<br />#endif<br />0001-Disable-Thumbnailrequest-preemption.patch:28: trailing whitespace.<br />#ifdef REQUESTQUEUE_PREEMPT<br />0001-Disable-Thumbnailrequest-preemption.patch:30: trailing whitespace.<br />#endif<br />error: Anwendung des Patches fehlgeschlagen: ImageManager/RequestQueue.cpp:47<br />error: ImageManager/RequestQueue.cpp: Patch konnte nicht angewendet werden</p>
<p>Using --whitespace=fix seems to fix it:</p>
<p><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">manfred@icg-pc217:~/src/kphotoalbum$ git apply --whitespace=fix 0001-Disable-Thumbnailrequest-preemption.patch<br /></span><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">0001-Disable-Thumbnailrequest-preemption.patch:18: trailing whitespace.<br /></span><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">#ifdef REQUESTQUEUE_PREEMPT<br /></span><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">0001-Disable-Thumbnailrequest-preemption.patch:25: trailing whitespace.<br /></span><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">#endif<br /></span><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">0001-Disable-Thumbnailrequest-preemption.patch:28: trailing whitespace.<br /></span><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">#ifdef REQUESTQUEUE_PREEMPT<br /></span><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">0001-Disable-Thumbnailrequest-preemption.patch:30: trailing whitespace.<br /></span><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">#endif<br /></span><span style="font-family: 'Lucida Grande', Verdana, Arial, Helvetica, sans-serif;">warning: 4 Zeilen fügen Fehler in Leerzeichen hinzu.</span></p>
<p>I hope this was the right thing to do?</p>
<p> </p>
<p> </p>
<p>Am 07.05.2013 21:55, schrieb Johannes Zarl:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px"><!-- html ignored --><!-- head ignored --><!-- meta ignored -->
<pre>Hello Manfred,
Just to try my theory out, could you please try the attached patch?
A quick way of attaching the patch to your clone of the repo is as follows:
$ git apply 0001-Disable-Thumbnailrequest-preemption.patch
The patch disables preemption of low priority thumbnail jobs by higher
priority ones. This should hopefully make the gui more responsive in your
specific situation.
Does the patch change anything for you?
Cheers,
Johannes
On Tuesday 07 May 2013 17:35:28 Johannes Zarl wrote:</pre>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px">On Tuesday 07 May 2013 17:15:54 you wrote:
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px">Hi Johannes, thanks. Unfortunately I have no idea what the issue could be. Maybe I can do some debugging when I have a bit more time than at the moment.</blockquote>
Assuming it's really a problem caused by file-system latency I'll try altering the priority-handling of the thumbnail scheduler so that it does not do preemption...
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px">Perhaps you should forward this mail also to the mailing list in case somebody else has any idea. I'm pretty sure it did not made it there. At least I didn't get it and it's also not visible in the archives: <a href="https://mail.kdab.com/pipermail/kphotoalbum/2013-May/thread.html">https://mail.kdab.com/pipermail/kphotoalbum/2013-May/thread.html</a> [1].</blockquote>
Ok, done. My bad. I always keep using the wrong address :-| Thanks, Johannes</blockquote>
</blockquote>
<p> </p>
</body></html>