[KPhotoAlbum] [PATCH] make grid around images optional

Jan Kundrát jkt at gentoo.org
Fri May 4 10:22:04 BST 2007


Henner Zeller wrote:
> Hi,
> I haven't applied this patch yet locally, but the
> 
> +    if (Settings::SettingsData::instance()->thumbnailDisplayGrid()) {
> 
> line should probably be
> 
> +    if (_mouseHandler->isResizingGrid() ||
> Settings::SettingsData::instance()->thumbnailDisplayGrid()) {
> 
> .. because when we resize the grid, we want to see gridlines.

Absolutely, thanks for correction. I missed that because this grid
resizing is another feature that I couldn't have used because I can't
really use middle button with mouse movement at the same time in my
particular setup.

Attached is the updated version of the patch which also makes resizing
work with left button and control key :), same as in my last patch for
enabling panning in Viewer.

Thanks again for your review,
-jkt

-- 
cd /local/pub && more beer > /dev/mouth
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: thumbnails-make-grid-optional-and-allow-resizing.patch
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20070504/e59fbd87/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20070504/e59fbd87/attachment.sig>


More information about the Kphotoalbum mailing list