<table><tr><td style="">jpalecek added a reviewer: Kopete.<br />jpalecek added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18444">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18444#inline-101953">View Inline</a><span style="color: #4b4d51; font-weight: bold;">bonjouraccount.cpp:241</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">ptrValue</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">&*</span><span class="n">pointer</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QObject</span><span style="color: #aa2211">::</span><span class="n">connect</span><span class="p">(</span><span class="n">ptrValue</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KDNSSD</span><span style="color: #aa2211">::</span><span class="n">RemoteService</span><span style="color: #aa2211">::</span><span class="n">resolved</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">ptrValue</span><span class="p">](</span><span style="color: #aa4000">bool</span> <span class="n">r</span><span class="p">)</span> <span class="p">{</span> <span class="n">comingOnlineResolved</span><span class="p">(</span><span class="n">KDNSSD</span><span style="color: #aa2211">::</span><span class="n">RemoteService</span><span style="color: #aa2211">::</span><span class="n">Ptr</span><span class="p">(</span><span class="n">ptrValue</span><span class="p">),</span> <span class="n">r</span><span class="p">);</span> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We use a raw pointer value here instead of RemoteService::Ptr, because that is a shared pointer which would create an ownership loop RemoteService -> (via signal-slot connection) lambda -> RemoteService (via captured variable).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R434 Kopete</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18444">https://phabricator.kde.org/D18444</a></div></div><br /><div><strong>To: </strong>jpalecek, Kopete<br /><strong>Cc: </strong>kopete-devel, himanshuvishwakarma, cochise<br /></div>