[kopete-bugs] [Bug 170160] [PATCH] colors aren't updated in actionMenu of most protocols

[Bartosz Szreder]

https://bugs.kde.org/show_bug.cgi?id=170160





--- Comment #12 from Bartosz Szreder <corpse fiend gmail com>  2009-03-28 01:16:55 ---
No, I don't have an account.

I'm doubting the quality of this patch. Tomas' color changing patch introduced
a colorChanged signal, which should be fired instead. My fix is actually a very
hackish way of dealing with the problem. And as I mentioned above, it fixes the
problem only partially.

I've learned of this signal quite late, when I was trying to track down other
places where appriopriate color change should take place, and was pretty
surprised that it isn't just emmited here and there. Then I realised that it
was quite a change to just use this signal in proper places - I had to include
headers and modify CMakeLists, just like in the proposed patch, but in more
invasive way, so it looked like it was not worth the effort (or maybe I'm not
doing it the right way, as I'm not accustomed to Kopete's internals).

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.