<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126881/">https://git.reviewboard.kde.org/r/126881/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konversation and Eike Hein.</div>
<div>By Safa Alfulaij.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2016, 1:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 5bc9e0ac69072e2f6fcb8be56d693c428994f4b9 by Safa Alfulaij to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=346137">346137</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Alignment of lines get missy when you use the Arabic version of Konversation. This patch will resolve all of the line types and get rid of old code with new shorter code.
Things to consider:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> I am not a native English speaker.
</em> I don't have any idea of how the coding style is, I just used what I saw in the file.
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> I don't know if there is a specific line width that I should consider.
</em> There is a problem with emotions if placed between two Arabic words, they will be positioned wrongly (Reported to upstream: https://bugreports.qt.io/browse/QTBUG-50619)
* I changed the way command messages got aligned, now it aligns according to the direction of the string rather than the count of RTL and LTR characters. It's better like this because an IP wouldn't contain RTL characters, which will make the count of LTR characters more, and that will aligns it to left, and will look bad.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">More to be done:
* Fix various issues with channel and nick names (Will be in a separate patch).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested all the types of lines and no issues at all. English version still looks as it is.
Please ignore the command lines that are aligned to left, I just need to fix (Or copy-paste) the translation file.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/viewer/ircview.cpp <span style="color: grey">(58bda65)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126881/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/89254d94-a636-4c7f-be32-d88ec298dec2__arabicLocale2.png">Server messages</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/c60a0232-8489-4cd3-bc64-c0887f1d8d30__arabicLocale3.png">Backlog, command and normal messages</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/94fbc807-1bbb-4035-bde4-f8ca06badf65__arabicLocale.png">Normal, action and command messages</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>