<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126436/">https://git.reviewboard.kde.org/r/126436/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konversation, Eli MacKenzie, Edward Baker, and Eike Hein.</div>
<div>By Anselmo L. S. Melo.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After the first use of "Close All Open Queries", the enabled state of
this action becomes inconsistent. This happens because:
When "Close All Open Queries" is executed
- closeQueries() sets m_queryViewCount to zero
- cleanupAfterClose() is called by each query that is being closed.
This slot decrements m_queryViewCount.
So, with n open queries, closeQueries() sets m_queryViewCount to zero,
then n calls to cleanupAfterClose() decrements m_queryViewCount, resulting
in a negative value. After that, "Close All Open Queries" enabled state
is not properly updated anymore.
This patch removes the m_queryViewCount = 0 from closeQueries(), leaving
the task of updating this counter to cleanupAfterClose().</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Opened and closed queries several times, closing them individually and also using "Close All Open Queries". With debug messages added to the code, I could verify that m_queryViewCount was being properly updated.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/viewer/viewcontainer.cpp <span style="color: grey">(8a384542412be05f8c858d5ba502f5238d4834bf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126436/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>