<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110261/">http://git.reviewboard.kde.org/r/110261/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just writing this down here, I talked to Eike about this feature and he thinks it's useful to have, but doesn't like adding a new colum to the tree widget (which I agree with). I will submit a patch which works without an extra column later.</pre>
<br />
<p>- Sven</p>
<br />
<p>On May 1st, 2013, 8:13 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konversation.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated May 1, 2013, 8:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a checkbox to the Highlighting configuration dialog,
which enables the user to choose for each highlighting option whether
it should trigger notifications (sound + tab highlight + systray
icon blinking) or not. This way, highlights can be used to color messages
in a channel without triggering a highlight every time coloring is
applied. This is especially useful in channels which have a lot of
bot-related traffic (#archlinux for example), since you can color each
message which is sent by a bot or which starts with "??" or so in grey,
making it far easier to follow the actual conversation (while still being
able to read the bot-messages, if you want).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing. The actual functionality, and saving settings seems to work okay.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.cpp <span style="color: grey">(7518183)</span></li>
<li>src/config/highlight_config.cpp <span style="color: grey">(721a737)</span></li>
<li>src/config/highlight_configui.ui <span style="color: grey">(61cebb8)</span></li>
<li>src/config/preferences.h <span style="color: grey">(8fc5141)</span></li>
<li>src/config/preferences.cpp <span style="color: grey">(a6dce69)</span></li>
<li>src/viewer/highlight.h <span style="color: grey">(52ed100)</span></li>
<li>src/viewer/highlight.cpp <span style="color: grey">(c8e02f5)</span></li>
<li>src/viewer/highlightviewitem.h <span style="color: grey">(211ff5b)</span></li>
<li>src/viewer/highlightviewitem.cpp <span style="color: grey">(969d23e)</span></li>
<li>src/viewer/ircview.cpp <span style="color: grey">(e778103)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110261/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>