<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103551/">http://git.reviewboard.kde.org/r/103551/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konversation.</div>
<div>By Thomas Capricelli.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2012, 8:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">
Thanks for the review. I agree with most remarks, especially the one about
'addressee', sorry for that. This new patch fix those issues.
I've installed kdepimlibs, which i hate, just to be able to test
compilation.
* Concerning the name, I thought ADDRESSBOOK_INTEGRATION was more
appropriate as it describes the feature, not he requirements. But you
decide, so i've changed it. I dont agree though.
* for the "doesn't belong to the topic of the patch", those were only
_comments_. It was only a hint for future people working on the file.
I've removed them as this concern you so much.
* the else after if (){ return} are _ugly_ and made me loose a lot of time
before understanding what's going on. I'd like to prevent this kind of
frustration to future devs.
I'm surprised by how nitpicking you are when I see the overall quality of
the code. I understand the code has a long history and so much devs worked on
it, I'm not blaming anyone.
Compilation of konversation here triggers a lot of warnings. I didn't even
notice my own ones.
This patch was tested with and without kdepimlibs installed. I tested cmake
(checking result of kdepim availability), compilation and checked against
which libs the resulting binary was linked.
Few random notes
* indentation in src/irc/nicksonline.h is ugly, i did not dare touching it.
* in src/irc/server.cpp:Server::setNickOffline, what if nickInfo is the
null pointer ? wasOnline checks for this, but there's not check here.. ??
* i only have this one warning when compiling without kdepimlibs
/usr/include/KDE/../kurifilter.h:732:110: warning: ‘ProviderInfoList’ is deprecated [-Wdeprecated-declarations]
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For people outthere like me that do not use KDE, the dependency on kdepim is a very huge one. We would very happily make the tradeoff of NOT being able to link nicknames to kde addressbook.
I guess you see the points, depending on kdepim brings two big problems
* installation/compilation : depending on kdepim brings half of kde packages, kdepim package and hence ugliness such as nepomuk/akonadi.
* at runtime, starting konversation, by the magic of dbus and KDE spaghetti runtime dependencies, it starts lot of unrelated KDE stuff daemons that takes both cpu and ram. I know this arg is denied by KDE zealot, but i stand on it.
So I did it. This patch allows compilation without kdepim. I've tried to keep the patch as minimal as possible of course.
I'm always on irc/freenode as 'orzel', and i'll be on #konversation for the next days.
Also, I do have commit rights on KDE (not sure about konversation proper, i did no follow the git migration very closely)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cmake with kdepim installed and with kdepim not installed
compiles tested with kdepim not installed: compiles, link and work fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c8df038)</span></li>
<li>config-konversation.h.cmake <span style="color: grey">(4aaf9d1)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a7ba9f4)</span></li>
<li>src/application.cpp <span style="color: grey">(038b403)</span></li>
<li>src/irc/nick.cpp <span style="color: grey">(298eafb)</span></li>
<li>src/irc/nickinfo.h <span style="color: grey">(20b8ef1)</span></li>
<li>src/irc/nickinfo.cpp <span style="color: grey">(e768d0d)</span></li>
<li>src/irc/nicksonline.h <span style="color: grey">(fbdd2cd)</span></li>
<li>src/irc/nicksonline.cpp <span style="color: grey">(8c9a4b1)</span></li>
<li>src/irc/outputfilter.cpp <span style="color: grey">(a7701e7)</span></li>
<li>src/irc/query.h <span style="color: grey">(3685a53)</span></li>
<li>src/irc/query.cpp <span style="color: grey">(1a432d4)</span></li>
<li>src/irc/server.h <span style="color: grey">(775cb7c)</span></li>
<li>src/irc/server.cpp <span style="color: grey">(f2d3168)</span></li>
<li>src/irc/serverison.h <span style="color: grey">(4500564)</span></li>
<li>src/irc/serverison.cpp <span style="color: grey">(f737b51)</span></li>
<li>src/konsolepanel.cpp <span style="color: grey">(14b32cc)</span></li>
<li>src/main.cpp <span style="color: grey">(f2c7a22)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(112dd39)</span></li>
<li>src/viewer/irccontextmenus.h <span style="color: grey">(40756d1)</span></li>
<li>src/viewer/irccontextmenus.cpp <span style="color: grey">(b735843)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103551/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>