<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100157/">http://git.reviewboard.kde.org/r/100157/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 18th, 2010, 4:08 p.m., <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KNotify is getting support for plugins in KDE 4.6, with config UI support for plugins scheduled for KDE 4.7. Wouldn't it make more sense to turn Message Indicator support into a KNotify plugin at that point, so apps don't need to be patched up individually nor duplicate the config UI?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KNotify has always supported "plugins". They were statically linked in the knotify binary though. Are they becoming dynamic with 4.6?
Anyway, I initially tried to implement message-indicator support as a new type of KNotify notification because I wanted to avoid patching applications, but it just doesn't fit. The m-i system lets the application provide a "server" which represents the application and multiple "indicators" which represent the incoming messages:
- The server is defined by a desktop file and can be triggered. The convention is to bring the application window to the front.
- An indicator consists of an icon, a text, an optional count and a flag to indicate whether it wants the user to pay attention to it. It can also be triggered, the convention in this case is to bring the application window to the front, and switch to the item represented by the indicator (In the case of Konversation, switch to the channel represented by the indicator)
I don't think this can be represented in KNotify.</pre>
<br />
<p>- Aurélien</p>
<br />
<p>On November 18th, 2010, 3:27 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konversation.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated 2010-11-18 15:27:06</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The message indicator (m-i) is a new way for applications to indicate incoming messages to their users. It has been developed by Canonical and is available for GNOME and KDE. To build m-i support you need libindicate-qt https://launchpad.net/libindicate-qt . For Konversation to show the messages, you need a m-i applet. There is a KDE Plasma widget which does this, available from https://launchpad.net/plasma-widget-message-indicator .</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kubuntu ships Konversation with this patch since a few releases now. I have been using it for a long time without problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(83c9f1d)</span></li>
<li>config-konversation.h.cmake <span style="color: grey">(c3fb529)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b063ee9)</span></li>
<li>src/config/konversation.kcfg <span style="color: grey">(c2b3d23)</span></li>
<li>src/config/messageindicator_config.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/config/settingsdialog.cpp <span style="color: grey">(169e7ed)</span></li>
<li>src/notificationhandler.h <span style="color: grey">(520d1ee)</span></li>
<li>src/notificationhandler.cpp <span style="color: grey">(f9a68de)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100157/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>